Skip to content

fix(react-message-bar): keep motion ref out of base hook #36549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martin Hochel (Hotell) merged 1 commit into from
Aug 13, 2026
+10 −3
Merged

fix(react-message-bar): keep motion ref out of base hook #36549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-message-bar-b83be573-581c-4db1-ae97-4e375b123a7d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
dmytrokirpa marked this conversation as resolved.
"type": "patch",
"comment": "Keep motion ref handling out of the headless MessageBar base hook.",
"packageName": "@fluentui/react-message-bar",
"email": "dmytrokirpa@microsoft.com",
"dependentChangeType": "patch"
}
6 changes: 3 additions & 3 deletions ...ges/react-components/react-message-bar/library/src/components/MessageBar/useMessageBar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const useMessageBarBase_unstable = (

// eslint-disable-next-line @typescript-eslint/no-deprecated
const { className: transitionClassName, nodeRef } = useMessageBarTransitionContext();
const motionRef = useMotionForwardedRef();

const actionsRef = React.useRef<HTMLDivElement | null>(null);
const bodyRef = React.useRef<HTMLDivElement | null>(null);
Expand All @@ -50,7 +49,7 @@ export const useMessageBarBase_unstable = (
},
root: slot.always(
getIntrinsicElementProps('div', {
ref: useMergedRefs(ref, reflowRef, nodeRef, motionRef),
ref: useMergedRefs(ref, reflowRef, nodeRef),
role: 'group',
'aria-labelledby': titleId,
...props,
Expand Down Expand Up @@ -86,7 +85,8 @@ export const useMessageBarBase_unstable = (
export const useMessageBar_unstable = (props: MessageBarProps, ref: React.Ref<HTMLDivElement>): MessageBarState => {
const { shape = 'rounded', ...baseProps } = props;

const state = useMessageBarBase_unstable(baseProps, ref);
const motionRef = useMotionForwardedRef();
const state = useMessageBarBase_unstable(baseProps, useMergedRefs(ref, motionRef));

return {
...state,
Expand Down
Loading