Feat(react-menu-grid-preview): Detect invalid MenuGrid nesting #35128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Hotell
reviewed
Sep 2, 2025
...nts/react-menu-grid-preview/library/src/components/MenuGridRow/useCheckMenuGridRowNesting.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-menu-grid-preview/library/src/utils/useCheckNesting.ts
Outdated
Show resolved
Hide resolved
...s/react-menu-grid-preview/library/src/components/MenuGridItem/useCheckMenuGridItemNesting.ts
Outdated
Show resolved
Hide resolved
...omponents/react-menu-grid-preview/library/src/components/MenuGrid/useCheckMenuGridNesting.ts
Outdated
Show resolved
Hide resolved
adamsamec
force-pushed
the
feat-detect-invalid-menu-grid-nesting
branch
from
5ac8512 to
42b818c
Compare
bsunderhus
approved these changes
Sep 3, 2025
...omponents/react-menu-grid-preview/library/src/components/MenuGrid/useCheckMenuGridNesting.ts
Outdated
Show resolved
Hide resolved
| export const useCheckNesting = (ref: React.RefObject<HTMLElement>, componentName: NestingComponentName): void => { | ||
| 'use no memo'; | ||
|
|
||
| const { targetDocument } = useFluent(); |
There was a problem hiding this comment.
You can move this hook inside the dev environment conditional also
ling1726
reviewed
Sep 3, 2025
| let current = ref.current?.parentElement; | ||
| let role = current?.getAttribute('role'); | ||
| while (current !== targetDocument?.body) { | ||
| if (role === 'grid' || role === 'menuitem') { |
There was a problem hiding this comment.
why is the menuitem role a breaking condition? Is it valid to put any of the MenuGrid components inside an element with role menuitem?
There was a problem hiding this comment.
I thought that placing MenuGrid into role="menuitem" should be allowed for the case that the MenuGrid is inserted inline.
ling1726
reviewed
Sep 3, 2025
...eact-components/react-menu-grid-preview/library/src/components/MenuGridRow/useMenuGridRow.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds a dev-only check for proper nesting of MenuGrid, MenuGridItem and MenuGridRow components, throwing an Error when invalid nesting is detected.