-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(priority-overflow): overflowMenuSize included in occupiedSize #35090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(priority-overflow): overflowMenuSize included in occupiedSize #35090
Conversation
Pull request demo site: URL |
📊 Bundle size reportUnchanged fixtures
|
change/@fluentui-priority-overflow-09409455-f841-4490-8f29-242e315804df.json
Show resolved
Hide resolved
ec2a4de
to
0458567
Compare
0458567
to
b5477b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to run build for react-overflow, so it will update public api md file :)
@@ -0,0 +1,7 @@ | |||
{ | |||
"type": "patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can omit this change file as correct one is with minor bump and feature scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. I had to run generate-api
because build
command ignored those changes, I've run it before
change/@fluentui-react-overflow-9b148d37-5471-4fe4-8c62-6bd3775221c5.json
Outdated
Show resolved
Hide resolved
…5221c5.json Co-authored-by: Victor Genaev <[email protected]>
OverflowMenu is not included in occupiedSize.
Overflow component contains only visible overflow items or hidden ones, but hidden because they don't fit the container.
If menu has default hidden items then overflowMenu is not included into calculation.
I added a new optional prop
hasHiddenItems
.Previous Behavior
New Behavior