Skip to content

Conversation

ValentinaKozlova
Copy link
Contributor

@ValentinaKozlova ValentinaKozlova commented Aug 25, 2025

OverflowMenu is not included in occupiedSize.
Overflow component contains only visible overflow items or hidden ones, but hidden because they don't fit the container.
If menu has default hidden items then overflowMenu is not included into calculation.

I added a new optional prop hasHiddenItems.

Previous Behavior

overflow-before

New Behavior

overflow-after

@ValentinaKozlova ValentinaKozlova self-assigned this Aug 25, 2025
@ValentinaKozlova ValentinaKozlova changed the title Fix/overflow occupied size menu fix(priority-overflow): overflowMenuSize included in occupiedSize. Aug 25, 2025
@ValentinaKozlova ValentinaKozlova changed the title fix(priority-overflow): overflowMenuSize included in occupiedSize. fix(priority-overflow): overflowMenuSize included in occupiedSize Aug 25, 2025
Copy link

Pull request demo site: URL

Copy link

github-actions bot commented Aug 25, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
priority-overflow
createOverflowManager
4.481 kB
1.864 kB
4.519 kB
1.881 kB
38 B
17 B
react-charts
AreaChart
384.134 kB
117.09 kB
384.245 kB
117.132 kB
111 B
42 B
react-charts
DeclarativeChart
679.241 kB
194.75 kB
679.352 kB
194.784 kB
111 B
34 B
react-charts
DonutChart
295.538 kB
88.297 kB
295.649 kB
88.337 kB
111 B
40 B
react-charts
FunnelChart
287.673 kB
85.539 kB
287.784 kB
85.581 kB
111 B
42 B
react-charts
GanttChart
367.443 kB
110.605 kB
367.554 kB
110.636 kB
111 B
31 B
react-charts
GaugeChart
310.71 kB
92.04 kB
310.821 kB
92.081 kB
111 B
41 B
react-charts
GroupedVerticalBarChart
370.86 kB
111.671 kB
370.971 kB
111.706 kB
111 B
35 B
react-charts
HeatMapChart
369.361 kB
112.199 kB
369.472 kB
112.236 kB
111 B
37 B
react-charts
HorizontalBarChart
295.206 kB
86.857 kB
295.317 kB
86.889 kB
111 B
32 B
react-charts
Legends
234.845 kB
69.479 kB
234.956 kB
69.515 kB
111 B
36 B
react-charts
LineChart
393.528 kB
118.622 kB
393.639 kB
118.66 kB
111 B
38 B
react-charts
ScatterChart
375.202 kB
113.155 kB
375.313 kB
113.195 kB
111 B
40 B
react-charts
VerticalBarChart
410.01 kB
118.705 kB
410.121 kB
118.742 kB
111 B
37 B
react-charts
VerticalStackedBarChart
381.752 kB
114.585 kB
381.863 kB
114.621 kB
111 B
36 B
react-components
react-components: entire library
1.284 MB
323.262 kB
1.284 MB
323.286 kB
111 B
24 B
react-overflow
hooks only
12.854 kB
4.828 kB
12.931 kB
4.85 kB
77 B
22 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-breadcrumb
@fluentui/react-breadcrumb - package
114.22 kB
31.522 kB
react-charts
HorizontalBarChartWithAxis
63 B
83 B
react-charts
SankeyChart
198.73 kB
61.034 kB
react-charts
Sparkline
91.123 kB
28.692 kB
react-components
react-components: Button, FluentProvider & webLightTheme
68.796 kB
19.903 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
236.614 kB
68.509 kB
react-components
react-components: FluentProvider & webLightTheme
43.63 kB
14.257 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
react-timepicker-compat
TimePicker
109.935 kB
36.335 kB
🤖 This report was generated against 624002a748b2d1ae3f5a429529f415c36f63c9f8

@ValentinaKozlova ValentinaKozlova force-pushed the fix/overflow-occupiedSize-menu branch 3 times, most recently from ec2a4de to 0458567 Compare August 27, 2025 14:04
@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review August 27, 2025 14:59
@ValentinaKozlova ValentinaKozlova requested review from a team as code owners August 27, 2025 14:59
@ValentinaKozlova ValentinaKozlova force-pushed the fix/overflow-occupiedSize-menu branch from 0458567 to b5477b1 Compare September 2, 2025 16:43
Copy link
Contributor

@mainframev mainframev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to run build for react-overflow, so it will update public api md file :)

@@ -0,0 +1,7 @@
{
"type": "patch",
Copy link
Contributor

@mainframev mainframev Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can omit this change file as correct one is with minor bump and feature scope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I had to run generate-api because build command ignored those changes, I've run it before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Overflow component incorrectly calculates width when using partitionBreadcrumbItems with always-visible menu
2 participants