fix: TeachingPopover arrow off by a pixel #31161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mltejera
reviewed
Apr 23, 2024
...t-teaching-popover/src/components/TeachingPopoverBody/useTeachingPopoverBodyStyles.styles.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Think you'll need to create a change file: |
...t-teaching-popover/src/components/TeachingPopoverBody/useTeachingPopoverBodyStyles.styles.ts
Outdated
Show resolved
Hide resolved
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 630 | 667 | 5000 | |
| Button | mount | 295 | 303 | 5000 | |
| Field | mount | 1127 | 1111 | 5000 | |
| FluentProvider | mount | 697 | 718 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 31 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 79 | 10 | |
| MakeStyles | mount | 856 | 863 | 50000 | |
| Persona | mount | 1803 | 1734 | 5000 | |
| SpinButton | mount | 1396 | 1388 | 5000 | |
| SwatchPicker | mount | 1534 | 1532 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
...hing-popover/src/components/TeachingPopoverSurface/useTeachingPopoverSurfaceStyles.styles.ts
Show resolved
Hide resolved
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
mltejera
reviewed
Apr 25, 2024
change/@fluentui-react-teaching-popover-b32cb5ff-1e29-4c94-bb2d-a5ad448d78f9.json
Outdated
Show resolved
Hide resolved
Mitch-At-Work
requested changes
Apr 25, 2024
...hing-popover/src/components/TeachingPopoverSurface/useTeachingPopoverSurfaceStyles.styles.ts
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
Change TeachingPopoverSurface boxSizing to account for shadow borders to help fix arrow placement. Address PR feedback Address PR Feedback Change TeachingPopoverSurface boxSizing to account for shadow borders to help fix arrow placement
EdDaWord
force-pushed
the
edwardwang/fix-teaching-popover-arrow-visual-bug
branch
from
0045857 to
a5a52e0
Compare
EdDaWord
changed the title
EdDaWord
changed the title
EdDaWord
changed the title
Mitch-At-Work
approved these changes
Apr 26, 2024
Contributor
Mitch-At-Work
left a comment
Mitch-At-Work
left a comment
There was a problem hiding this comment.
Looks good! Let's put a slightly more descriptive changelog comment then good to go
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Co-authored-by: Edward Wang <edwardwang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The arrow is off by 1px
New Behavior
The arrow is no longer off by 1px
Related Issue(s)
Previously the
...shorthands.borderWidth('0px'),was introduced here: #30270It was done so because the items within the TeachingPopoverSurface did not align:
By changing the
boxSizingfrom'border-box'to'content-box'open questions?