-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(react-combobox): rollback export of internal hooks #30648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-combobox/chore--rollback-export-of-internal-hooks
Feb 29, 2024
Merged
chore(react-combobox): rollback export of internal hooks #30648
bsunderhus
merged 1 commit into
microsoft:master
from
bsunderhus:react-combobox/chore--rollback-export-of-internal-hooks
Feb 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
approved these changes
Feb 28, 2024
3bcd7da
to
4a3035e
Compare
📊 Bundle size reportUnchanged fixtures
|
4a3035e
to
926913d
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
/azp-run |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 65 | 61 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 660 | 644 | 5000 | |
Button | mount | 321 | 301 | 5000 | |
Field | mount | 1116 | 1146 | 5000 | |
FluentProvider | mount | 692 | 732 | 5000 | |
FluentProviderWithTheme | mount | 79 | 81 | 10 | |
FluentProviderWithTheme | virtual-rerender | 65 | 61 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 70 | 10 | |
MakeStyles | mount | 847 | 849 | 50000 | |
Persona | mount | 1724 | 1720 | 5000 | |
SpinButton | mount | 1372 | 1375 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
react-combobox
toreact-tag-picker-preview
package manuallyRelated Issue(s)