Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jan 31, 2024

Previous Behavior

onFocus and onBlur properties were being ignore from TreeItem due to a regression introduced in #29694

New Behavior

Ensures that onFocus and onBlur are properly provided to the root element for TreeItem

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 31, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 635 634 5000
Button mount 319 316 5000
Field mount 1152 1123 5000
FluentProvider mount 706 687 5000
FluentProviderWithTheme mount 73 85 10
FluentProviderWithTheme virtual-rerender 74 63 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 73 10
MakeStyles mount 847 858 50000
Persona mount 1819 1721 5000
SpinButton mount 1370 1356 5000

@bsunderhus bsunderhus force-pushed the react-tree/bugfix--ensure-focus-and-blur-events-on-TreeItem branch from 652863d to 24d9ad0 Compare January 31, 2024 09:23
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 31, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Button, FluentProvider & webLightTheme
69.901 kB
20.261 kB
70.688 kB
20.464 kB
787 B
203 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
210.849 kB
60.149 kB
217.02 kB
61.894 kB
6.171 kB
1.745 kB
react-components
react-components: FluentProvider & webLightTheme
42.388 kB
14.103 kB
43.173 kB
14.298 kB
785 B
195 B
react-portal-compat
PortalCompatProvider
7.099 kB
2.385 kB
7.902 kB
2.586 kB
803 B
201 B

🤖 This report was generated against 491d0cb952b14057711ff36348da50db92eaf78d

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 31, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d06b132:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 31, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-tree/bugfix--ensure-focus-and-blur-events-on-TreeItem branch from 24d9ad0 to d06b132 Compare January 31, 2024 12:43
@bsunderhus bsunderhus merged commit 449162d into microsoft:master Jan 31, 2024
@bsunderhus bsunderhus deleted the react-tree/bugfix--ensure-focus-and-blur-events-on-TreeItem branch January 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants