Skip to content

Conversation

@smhigley
Copy link
Contributor

Previous Behavior

Related to #25342 -- that PR fixed this same issue for when the header row is entirely absent. The issue still presents when the DetailsList header is present but not focusable (i.e. by disabling both selection and columnActionsMode).

New Behavior

The first row of the DetailsList body is now always in the tab order. When I was taking another look at the earlier fix, I realized that there's no use case when we wouldn't want the first content row to be in the tab order, since the headers are a separate tab stop from the body.

Related Issue(s)

@smhigley smhigley requested review from a team, ThomasMichon and spmonahan as code owners January 24, 2024 21:38
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1627cab:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 24, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 24, 2024

📊 Bundle size report

🤖 This report was generated against be3a3d59d5c30f75d55c739548d576594ddf5c53

@size-auditor
Copy link

size-auditor bot commented Jan 24, 2024

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-DetailsList 225.889 kB 225.886 kB BelowBaseline     -3 bytes
office-ui-fabric-react fluentui-react-ShimmeredDetailsList 236.657 kB 236.654 kB BelowBaseline     -3 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: be3a3d59d5c30f75d55c739548d576594ddf5c53 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 24, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 655 616 5000
Breadcrumb mount 1662 1657 1000
Checkbox mount 1651 1641 5000
CheckboxBase mount 1481 1471 5000
ChoiceGroup mount 2976 2917 5000
ComboBox mount 647 656 1000
CommandBar mount 6168 6187 1000
ContextualMenu mount 12063 12146 1000
DefaultButton mount 736 755 5000
DetailsRow mount 2161 2176 5000
DetailsRowFast mount 2229 2203 5000
DetailsRowNoStyles mount 2029 2033 5000
Dialog mount 2650 2666 1000
DocumentCardTitle mount 230 234 1000
Dropdown mount 1987 1952 5000
FocusTrapZone mount 1111 1157 5000
FocusZone mount 1067 1049 5000
GroupedList mount 41891 41723 2
GroupedList virtual-rerender 19965 20102 2
GroupedList virtual-rerender-with-unmount 50563 50707 2
GroupedListV2 mount 226 222 2
GroupedListV2 virtual-rerender 207 201 2
GroupedListV2 virtual-rerender-with-unmount 223 225 2
IconButton mount 1089 1091 5000
Label mount 346 339 5000
Layer mount 2685 2689 5000
Link mount 380 390 5000
MenuButton mount 936 958 5000
MessageBar mount 21438 21820 5000
Nav mount 1985 1954 1000
OverflowSet mount 787 777 5000
Panel mount 1791 1758 1000
Persona mount 710 724 1000
Pivot mount 878 860 1000
PrimaryButton mount 846 836 5000
Rating mount 4638 4601 5000
SearchBox mount 917 926 5000
Shimmer mount 1949 1856 5000
Slider mount 1323 1332 5000
SpinButton mount 2905 2882 5000
Spinner mount 386 388 5000
SplitButton mount 1856 1836 5000
Stack mount 418 412 5000
StackWithIntrinsicChildren mount 853 860 5000
StackWithTextChildren mount 2590 2561 5000
SwatchColorPicker mount 6250 6219 5000
TagPicker mount 1470 1444 5000
Text mount 373 371 5000
TextField mount 931 939 5000
ThemeProvider mount 830 830 5000
ThemeProvider virtual-rerender 589 585 5000
ThemeProvider virtual-rerender-with-unmount 1281 1283 5000
Toggle mount 600 611 5000
buttonNative mount 189 204 5000

@smhigley smhigley merged commit c0981cf into microsoft:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants