Skip to content

fix(fluentui-publish): remove dist-tag leftover from options as canary was removed #30347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 1 commit into from
Jan 25, 2024
Merged

fix(fluentui-publish): remove dist-tag leftover from options as canary was removed #30347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions scripts/fluentui-publish/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import * as yargs from 'yargs';

main();

function fluentuiLernaPublish(bumpType: 'patch' | 'minor', skipConfirm = false, npmTagForCanary = 'beta') {
function fluentuiLernaPublish(bumpType: 'patch' | 'minor', skipConfirm = false) {
const fluentRoot = path.resolve(workspaceRoot, 'packages', 'fluentui');

let lernaPublishArgs: string[];
Expand Down Expand Up @@ -87,14 +87,14 @@ function main() {
const command = args._[0];

if (command === 'bump') {
const { semverType, yes, distTag, postValidate } = args as unknown as {
const { semverType, yes, postValidate } = args as unknown as {
semverType: 'patch' | 'minor';
distTag?: string;
yes: boolean;
postValidate: boolean;
};

fluentuiLernaPublish(semverType, yes, distTag);
fluentuiLernaPublish(semverType, yes);
postValidate && fluentuiPostPublishValidation();

return;
Expand Down Expand Up @@ -122,10 +122,6 @@ function processArgs() {
type: 'boolean',
default: true,
description: 'execute validation steps after publish',
})
.option('dist-tag', {
type: 'string',
description: 'tag for canary release',
});
})
.demandCommand(1)
Expand Down