-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: export AnnounceProvider & useAnnounce() #30328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
layershifter
merged 2 commits into
microsoft:master
from
layershifter:feat/export-useannounce
Jan 17, 2024
Merged
feat: export AnnounceProvider & useAnnounce() #30328
layershifter
merged 2 commits into
microsoft:master
from
layershifter:feat/export-useannounce
Jan 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
c90cce2 to
360097e
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 646 | 625 | 5000 | |
| Button | mount | 293 | 311 | 5000 | |
| Field | mount | 1142 | 1170 | 5000 | |
| FluentProvider | mount | 695 | 724 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 62 | 72 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 72 | 10 | |
| MakeStyles | mount | 864 | 862 | 50000 | |
| Persona | mount | 1753 | 1777 | 5000 | |
| SpinButton | mount | 1375 | 1406 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a64c26d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d98dd58264f2dbfaaf0c3cc1c7149acf0b8a6266 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
360097e to
2c19189
Compare
ling1726
reviewed
Jan 16, 2024
...ges/react-components/react-shared-contexts/stories/UseAnnouce/UseAnnounceDefault.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Jan 16, 2024
packages/react-components/react-shared-contexts/stories/UseAnnouce/UseAnnounceDescription.md
Outdated
Show resolved
Hide resolved
ling1726
approved these changes
Jan 16, 2024
ling1726
reviewed
Jan 16, 2024
packages/react-components/react-shared-contexts/stories/UseAnnouce/UseAnnounceDescription.md
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Jan 17, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR exports:
AnnounceProviderto inject implementation ofannounce()functionuseAnnounce()to trigger announcementsAlso adds documentation for
useAnnounce().Sample implementation of announcer will be added separately.
AnnounceProvider_unstable,useAnnounce_unstable&AnnounceContextValue_unstablein@fluentui/react-shared-componentsin favor of "stable" exportsAnnounceOptionstypeRelated Issue(s)
Related #29371.
Related #28654.