fix(react-migration-v0-v9): add northstar to dependencies #30303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
added
Fluent UI react-components (v9)
Fluent UI react-northstar (v0)
Hotell
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bf77fb5:
|
Collaborator
📊 Bundle size report🤖 This report was generated against ff13b22331371b7030db49b0fa760dd5ac12cbba |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ff13b22331371b7030db49b0fa760dd5ac12cbba (build) |
ling1726
reviewed
Jan 12, 2024
ling1726
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
northstar is specified only as a devDependency but its actually being used in public api surface. (discovered #30251)
New Behavior
northstar is properly set as dependency
Related Issue(s)