Skip to content

ci: bump devcontainer to node 18 #29759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 1 commit into from
Nov 6, 2023
Merged

ci: bump devcontainer to node 18 #29759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM mcr.microsoft.com/devcontainers/typescript-node:1-16-bookworm
ARG VARIANT=18-bookworm
# https://github.com/devcontainers/images/tree/main/src/typescript-node
FROM mcr.microsoft.com/devcontainers/typescript-node:1-${VARIANT}

# Cypress linux pre-requisites https://docs.cypress.io/guides/getting-started/installing-cypress#Linux-Prerequisites
RUN apt-get update && apt-get -y install libgtk2.0-0 libgtk-3-0 libgbm-dev libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 libxtst6 xauth xvfb
2 changes: 1 addition & 1 deletion .devcontainer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This configuration is based on the base Node container provided by VSCode, it sh

> For more information on how to use/create `development containers` follow the [VSCode Documentation](https://code.visualstudio.com/docs/remote/create-dev-container)

> See here for more information on the base container https://github.com/microsoft/vscode-dev-containers/tree/v0.222.0/containers/javascript-node/.devcontainer/base.Dockerfile
> See here for more information on the base container https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node/.devcontainer/base.Dockerfile

## Cypress tests

Expand Down
5 changes: 4 additions & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
{
"name": "Node.js",
"build": {
"dockerfile": "Dockerfile"
"dockerfile": "Dockerfile",
"args": {
"VARIANT": "18-bookworm"
}
},
"features": {
"ghcr.io/devcontainers/features/github-cli:1": {}
Expand Down
2 changes: 2 additions & 0 deletions lage.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ module.exports = {
'change/**',
'rfcs/**',
'README.md',
'*.md',
'.vscode/**',
'.github/*.yml',
'.github/*.json',
Expand All @@ -35,6 +36,7 @@ module.exports = {
'.github/MAINTAINERS',
'.github/ISSUE_TEMPLATE/**',
'.github/policies/**',
'.devcontainer/**',
],

// All of these options are sent to `backfill`: https://github.com/microsoft/backfill/blob/master/README.md
Expand Down