Skip to content

Conversation

@dannyvv
Copy link
Member

@dannyvv dannyvv commented Oct 31, 2023

Remove redundant pipeline yaml.
It is now replaced with azure-pipelines-ci.yml (master run) and azure-pipelines-pr.yml (PR run)

@dannyvv dannyvv requested a review from a team as a code owner October 31, 2023 17:19
@Hotell Hotell changed the title Remove redundant pipeline yaml. ci: remove old pipeline definition used for PRs Oct 31, 2023
@Hotell Hotell added the CI label Oct 31, 2023
@Hotell Hotell enabled auto-merge (squash) October 31, 2023 17:24
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 626 657 5000
Button mount 317 314 5000
Field mount 1139 1100 5000
FluentProvider mount 698 714 5000
FluentProviderWithTheme mount 80 84 10
FluentProviderWithTheme virtual-rerender 66 71 10
FluentProviderWithTheme virtual-rerender-with-unmount 78 78 10
MakeStyles mount 846 861 50000
Persona mount 1679 1700 5000
SpinButton mount 1392 1433 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 51a6fb6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 113 98 1.15:1
ChatWithPopoverPerf.default 211 190 1.11:1
ChatDuplicateMessagesPerf.default 159 144 1.1:1
AlertMinimalPerf.default 159 149 1.07:1
SegmentMinimalPerf.default 200 187 1.07:1
TreeWith60ListItems.default 94 88 1.07:1
LayoutMinimalPerf.default 199 188 1.06:1
LabelMinimalPerf.default 229 219 1.05:1
FlexMinimalPerf.default 162 156 1.04:1
FormMinimalPerf.default 227 219 1.04:1
GridMinimalPerf.default 192 184 1.04:1
ListWith60ListItems.default 375 360 1.04:1
SliderMinimalPerf.default 749 722 1.04:1
SplitButtonMinimalPerf.default 2282 2197 1.04:1
TextMinimalPerf.default 195 189 1.03:1
BoxMinimalPerf.default 198 194 1.02:1
ButtonMinimalPerf.default 91 89 1.02:1
CardMinimalPerf.default 311 305 1.02:1
CarouselMinimalPerf.default 266 262 1.02:1
ChatMinimalPerf.default 443 433 1.02:1
DropdownManyItemsPerf.default 388 380 1.02:1
DropdownMinimalPerf.default 1422 1392 1.02:1
ItemLayoutMinimalPerf.default 708 694 1.02:1
PortalMinimalPerf.default 88 86 1.02:1
ReactionMinimalPerf.default 211 207 1.02:1
TextAreaMinimalPerf.default 297 291 1.02:1
CustomToolbarPrototype.default 1481 1459 1.02:1
TooltipMinimalPerf.default 1321 1297 1.02:1
DialogMinimalPerf.default 448 442 1.01:1
DividerMinimalPerf.default 197 195 1.01:1
HeaderSlotsPerf.default 478 473 1.01:1
ProviderMinimalPerf.default 205 203 1.01:1
RadioGroupMinimalPerf.default 261 258 1.01:1
ButtonOverridesMissPerf.default 650 653 1:1
DatepickerMinimalPerf.default 3601 3619 1:1
EmbedMinimalPerf.default 1854 1852 1:1
ListMinimalPerf.default 304 303 1:1
MenuButtonMinimalPerf.default 963 960 1:1
PopupMinimalPerf.default 350 350 1:1
IconMinimalPerf.default 385 385 1:1
TableMinimalPerf.default 229 230 1:1
ToolbarMinimalPerf.default 530 528 1:1
AnimationMinimalPerf.default 296 298 0.99:1
CheckboxMinimalPerf.default 1120 1136 0.99:1
LoaderMinimalPerf.default 185 187 0.99:1
MenuMinimalPerf.default 494 498 0.99:1
TableManyItemsPerf.default 1105 1113 0.99:1
AccordionMinimalPerf.default 85 87 0.98:1
ButtonSlotsPerf.default 309 314 0.98:1
ProviderMergeThemesPerf.default 645 660 0.98:1
AttachmentSlotsPerf.default 649 667 0.97:1
InputMinimalPerf.default 534 553 0.97:1
ListNestedPerf.default 315 324 0.97:1
TreeMinimalPerf.default 471 485 0.97:1
VideoMinimalPerf.default 430 444 0.97:1
RosterPerf.default 1536 1600 0.96:1
RefMinimalPerf.default 107 111 0.96:1
SkeletonMinimalPerf.default 187 194 0.96:1
StatusMinimalPerf.default 387 403 0.96:1
HeaderMinimalPerf.default 200 210 0.95:1
ImageMinimalPerf.default 217 230 0.94:1
ListCommonPerf.default 375 415 0.9:1
AttachmentMinimalPerf.default 80 97 0.82:1

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.341 kB
1.81 kB
react-accordion
Accordion (including children components)
92.983 kB
28.418 kB
react-alert
Alert
84.293 kB
23.456 kB
react-avatar
Avatar
50.534 kB
15.923 kB
react-avatar
AvatarGroup
20.064 kB
7.894 kB
react-avatar
AvatarGroupItem
65.19 kB
20.259 kB
react-badge
Badge
27.264 kB
8.808 kB
react-badge
CounterBadge
28.165 kB
9.101 kB
react-badge
PresenceBadge
25.67 kB
9.313 kB
react-button
Button
40.074 kB
11.292 kB
react-button
CompoundButton
47.43 kB
12.787 kB
react-button
MenuButton
44.848 kB
12.668 kB
react-button
SplitButton
52.862 kB
14.254 kB
react-button
ToggleButton
57.122 kB
13.194 kB
react-calendar-compat
Calendar Compat
141.324 kB
36.821 kB
react-card
Card - All
92.955 kB
26.977 kB
react-card
Card
87.781 kB
25.462 kB
react-card
CardFooter
13.423 kB
5.481 kB
react-card
CardHeader
15.666 kB
6.235 kB
react-card
CardPreview
14.374 kB
5.854 kB
react-checkbox
Checkbox
37.505 kB
12.327 kB
react-combobox
Combobox (including child components)
91.781 kB
29.935 kB
react-combobox
Dropdown (including child components)
90.223 kB
29.601 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.002 kB
20.161 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.417 kB
59.289 kB
react-components
react-components: FluentProvider & webLightTheme
42.286 kB
14 kB
react-datepicker-compat
DatePicker Compat
212.494 kB
59.326 kB
react-dialog
Dialog (including children components)
94.473 kB
28.28 kB
react-divider
Divider
21.179 kB
7.839 kB
react-field
Field
22.788 kB
8.639 kB
react-image
Image
16.096 kB
6.317 kB
react-infobutton
InfoButton
130.729 kB
41.194 kB
react-infobutton
InfoLabel
134.413 kB
42.351 kB
react-input
Input
27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime
4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime
4.734 kB
1.983 kB
react-label
Label
14.508 kB
5.857 kB
react-link
Link
17.4 kB
6.977 kB
react-menu
Menu (including children components)
140.176 kB
43.004 kB
react-menu
Menu (including selectable components)
142.862 kB
43.51 kB
react-message-bar
MessageBar (all components)
25.54 kB
9.102 kB
react-overflow
hooks only
12.598 kB
4.754 kB
react-persona
Persona
57.425 kB
17.798 kB
react-popover
Popover
119.46 kB
37.714 kB
react-portal
Portal
12.4 kB
4.541 kB
react-portal-compat
PortalCompatProvider
6.651 kB
2.252 kB
react-positioning
usePositioning
25.305 kB
9.162 kB
react-progress
ProgressBar
17.788 kB
6.986 kB
react-provider
FluentProvider
22.831 kB
8.429 kB
react-radio
Radio
31.266 kB
10.267 kB
react-radio
RadioGroup
15.704 kB
6.35 kB
react-select
Select
28.968 kB
10.269 kB
react-slider
Slider
38.349 kB
12.595 kB
react-spinbutton
SpinButton
37.133 kB
11.856 kB
react-spinner
Spinner
23.762 kB
8.556 kB
react-switch
Switch
33.731 kB
10.899 kB
react-table
DataGrid
157.084 kB
43.906 kB
react-table
Table (Primitives only)
43.941 kB
13.76 kB
react-table
Table as DataGrid
130.165 kB
35.174 kB
react-table
Table (Selection only)
75.777 kB
20.477 kB
react-table
Table (Sort only)
74.384 kB
20.075 kB
react-tags
InteractionTag
15.618 kB
6.152 kB
react-tags
Tag
30.341 kB
9.505 kB
react-tags
TagGroup
73.816 kB
22.097 kB
react-text
Text - Default
17.065 kB
6.645 kB
react-text
Text - Wrappers
20.237 kB
6.965 kB
react-textarea
Textarea
31.306 kB
10.549 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-toast
Toast (including Toaster)
92.725 kB
27.876 kB
react-tooltip
Tooltip
52.466 kB
18.466 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against d4664628ced0837e16fd0cb20c79ba66030ed33d

@size-auditor
Copy link

size-auditor bot commented Oct 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d4664628ced0837e16fd0cb20c79ba66030ed33d (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 622 623 5000
Breadcrumb mount 1672 1677 1000
Checkbox mount 1672 1677 5000
CheckboxBase mount 1476 1472 5000
ChoiceGroup mount 2915 2898 5000
ComboBox mount 651 645 1000
CommandBar mount 6355 6284 1000
ContextualMenu mount 14481 15169 1000
DefaultButton mount 750 749 5000
DetailsRow mount 2143 2135 5000
DetailsRowFast mount 2215 2134 5000
DetailsRowNoStyles mount 2015 1973 5000
Dialog mount 2791 2724 1000
DocumentCardTitle mount 224 226 1000
Dropdown mount 1966 1958 5000
FocusTrapZone mount 1151 1108 5000
FocusZone mount 1048 1067 5000
GroupedList mount 41481 41776 2
GroupedList virtual-rerender 20192 20066 2
GroupedList virtual-rerender-with-unmount 51432 50552 2
GroupedListV2 mount 225 230 2
GroupedListV2 virtual-rerender 231 216 2
GroupedListV2 virtual-rerender-with-unmount 233 230 2
IconButton mount 1053 1065 5000
Label mount 352 326 5000
Layer mount 2716 2734 5000
Link mount 388 389 5000
MenuButton mount 933 942 5000
MessageBar mount 21713 21586 5000
Nav mount 1915 1998 1000
OverflowSet mount 780 785 5000
Panel mount 2059 1806 1000
Persona mount 756 725 1000
Pivot mount 871 880 1000
PrimaryButton mount 836 836 5000
Rating mount 4633 4567 5000
SearchBox mount 898 906 5000
Shimmer mount 1880 1883 5000
Slider mount 1347 1307 5000
SpinButton mount 2801 2877 5000
Spinner mount 392 392 5000
SplitButton mount 1821 1761 5000
Stack mount 419 405 5000
StackWithIntrinsicChildren mount 833 841 5000
StackWithTextChildren mount 2601 2599 5000
SwatchColorPicker mount 6129 6120 5000
TagPicker mount 1417 1446 5000
Text mount 371 378 5000
TextField mount 912 955 5000
ThemeProvider mount 853 841 5000
ThemeProvider virtual-rerender 587 593 5000
ThemeProvider virtual-rerender-with-unmount 1278 1277 5000
Toggle mount 623 593 5000
buttonNative mount 194 200 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell merged commit 6ce4a1b into microsoft:master Oct 31, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 31, 2023
* master: (34 commits)
  Remove redundant pipeline yaml. It is now replaced iwth azure-pipelines-ci.yml and azure-pipelines-pr.yml (microsoft#29706)
  chore(TimePicker-compat): preview release with added stories and docs (microsoft#29677)
  Enable 1ES PT to be compliant for all production pipelines (microsoft#29702)
  chore: restrict  node versions to 18 ||| 20 (microsoft#29676)
  chore(TimePicker-compat): renames and code polish (microsoft#29695)
  chore: remove animation from test environments (microsoft#29692)
  applying package updates
  docs: fix defaultSelectedOptions for Dropdown and Combobox examples (microsoft#29700)
  revert accidentally pushed changes (microsoft#29696)
  Added scale factor to minHeight logic (microsoft#29653)
  Fixing the mistake in useArrowNavigationGroup - axis values in the doc (microsoft#29667)
  applying package updates
  🧪
  🧪
  🧪
  🧪
  🧪
  Rever accidentally pushed pipeline changes (microsoft#29685)
  applying package updates
  🧪
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants