Skip to content

fix(react-drawer): accessibility tweaks #29627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcosmoura merged 8 commits into from
Oct 26, 2023
Merged

fix(react-drawer): accessibility tweaks #29627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee87c87
fix: show border separator when high contrast mode
marcosmoura Oct 24, 2023
57b1dc7
fix: disable backdrop transition when reduced motion
marcosmoura Oct 24, 2023
dbfc90e
fix: add missing changelog
marcosmoura Oct 24, 2023
dcf4daa
fix: update cypress tests
marcosmoura Oct 24, 2023
2ec20a0
fix: update cypress tests
marcosmoura Oct 24, 2023
6174504
fix: update cypress tests
marcosmoura Oct 25, 2023
65db07b
fix: update cypress tests
marcosmoura Oct 25, 2023
6a86238
fix: update cypress tests
marcosmoura Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-drawer-b7d10669-1f23-47cb-bc3e-21e001e940f1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: improve high contrast mode",
"packageName": "@fluentui/react-drawer",
"email": "[email protected]",
"dependentChangeType": "patch"
}
13 changes: 2 additions & 11 deletions packages/react-components/react-drawer/src/components/DrawerInline/DrawerInline.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,16 @@ describe('DrawerInline', () => {
testDrawerBaseScenarios(DrawerInline);

describe('separator prop', () => {
it('should not render any border when separator is false', () => {
mountFluent(<DrawerInline id="drawer" position="start" open />);

cy.get('#drawer').should('not.have.css', `border-right-width`, '1px');
cy.get('#drawer').should('not.have.css', `border-left-width`, '1px');
});

it('should render correct border when when position is `start`', () => {
mountFluent(<DrawerInline id="drawer" position="start" separator open />);

cy.get('#drawer').should('not.have.css', `border-left-width`, '1px');
cy.get('#drawer').should('have.css', `border-right-width`, '1px');
cy.get('#drawer').should('not.have.css', `border-right-color`, 'transparent');
});

it('should render correct border when when position is `end`', () => {
mountFluent(<DrawerInline id="drawer" position="end" separator open />);

cy.get('#drawer').should('not.have.css', `border-right-width`, '1px');
cy.get('#drawer').should('have.css', `border-left-width`, '1px');
cy.get('#drawer').should('not.have.css', `border-left-color`, 'transparent');
});
});
});
4 changes: 4 additions & 0 deletions ...act-components/react-drawer/src/components/DrawerOverlay/useDrawerOverlayStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ const useBackdropStyles = makeStyles({
transitionProperty: 'opacity',
transitionTimingFunction: tokens.curveEasyEase,
willChange: 'opacity',

'@media screen and (prefers-reduced-motion: reduce)': {
transitionDuration: '0.001ms',
},
},

visible: {
Expand Down
4 changes: 4 additions & 0 deletions packages/react-components/react-drawer/src/shared/useDrawerBaseStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,14 @@ const useDrawerStyles = makeStyles({

/* Positioning */
start: {
...shorthands.borderRight(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStroke),

left: 0,
right: 'auto',
},
end: {
...shorthands.borderLeft(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStroke),

right: 0,
left: 'auto',
},
Expand Down