Skip to content

chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app #29603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 5 commits into from
Oct 21, 2023
Merged

chore(vr-tests-react-components, perf-tests-app): Remove infobutton from vr-tests and perf test app #29603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98acf6f
chore: Update vr-tests to only use react-infolabel.
sopranopillow Oct 19, 2023
af32938
remove infobutton from perf app
sopranopillow Oct 19, 2023
a12135b
update dependency
sopranopillow Oct 19, 2023
8d8aa3b
fix verison issue
sopranopillow Oct 19, 2023
a440fcd
make single story for sizes
sopranopillow Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/perf-test-react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"@fluentui/react-avatar": "*",
"@fluentui/react-button": "*",
"@fluentui/react-field": "*",
"@fluentui/react-infobutton": ">=9.0.0-alpha",
"@fluentui/react-persona": "*",
"@fluentui/react-provider": "*",
"@fluentui/react-spinbutton": "*",
Expand Down
12 changes: 0 additions & 12 deletions apps/perf-test-react-components/src/scenarios/InfoButton.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@fluentui/react-field": "*",
"@fluentui/react-icons": "^2.0.217",
"@fluentui/react-image": "*",
"@fluentui/react-infobutton": ">=9.0.0-alpha",
"@fluentui/react-infolabel": ">=9.0.0-alpha",
"@fluentui/react-input": "*",
"@fluentui/react-label": "*",
"@fluentui/react-link": "*",
Expand Down
59 changes: 0 additions & 59 deletions apps/vr-tests-react-components/src/stories/InfoButton.stories.tsx
View file
Open in desktop

This file was deleted.

21 changes: 19 additions & 2 deletions apps/vr-tests-react-components/src/stories/InfoLabel.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';

import { Steps, StoryWright } from 'storywright';
import { InfoLabel } from '@fluentui/react-infobutton';
import { InfoLabel } from '@fluentui/react-infolabel';
import { storiesOf } from '@storybook/react';
import { TestWrapperDecoratorFixedWidth } from '../utilities/TestWrapperDecorator';

Expand Down Expand Up @@ -40,4 +40,21 @@ storiesOf('InfoLabel', module)
{
includeRtl: true,
},
);
)
.addStory('sizes -- open', () => (
<div
style={{
display: 'flex',
flexDirection: 'column',
paddingTop: '60px',
paddingLeft: '10px',
paddingBottom: '10px',
gap: '80px',
alignItems: 'start',
}}
>
<InfoLabel size="small" info="This is the content of an InfoButton." infoButton={{ popover: { open: true } }} />
<InfoLabel size="medium" info="This is the content of an InfoButton." infoButton={{ popover: { open: true } }} />
<InfoLabel size="large" info="This is the content of an InfoButton." infoButton={{ popover: { open: true } }} />
</div>
));