Skip to content

Fix missing x callout custom callout #29547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AtishayMsft merged 2 commits into from
Oct 19, 2023
Merged

Fix missing x callout custom callout #29547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87fdb35
Added missing xAxisCallout param in calloutData
Shubhabrata08 Oct 17, 2023
f09d686
Added changefile
Shubhabrata08 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-f831c35a-e12e-458d-9a22-de0345f66557.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Added missing xAxisCalloutData param while fetching callout data",
"packageName": "@fluentui/react-charting",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 4 additions & 0 deletions packages/react-charting/src/utilities/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,7 @@ export function calloutData(values: (ILineChartPoints & { index?: number })[]) {
legend: string;
y: number;
color: string;
xAxisCalloutData?: string;
yAxisCalloutData?: string | { [id: string]: number };
callOutAccessibilityData?: IAccessibilityProps;
index?: number;
Expand All @@ -510,6 +511,7 @@ export function calloutData(values: (ILineChartPoints & { index?: number })[]) {
legend: string;
y: number;
color: string;
xAxisCalloutData?: string;
yAxisCalloutData?: string | { [id: string]: number };
callOutAccessibilityData?: IAccessibilityProps;
index?: number;
Expand All @@ -522,6 +524,7 @@ export function calloutData(values: (ILineChartPoints & { index?: number })[]) {
legend: ele.legend,
y: ele.y,
color: ele.color!,
xAxisCalloutData: ele.xAxisCalloutData,
yAxisCalloutData: ele.yAxisCalloutData,
callOutAccessibilityData: ele.callOutAccessibilityData,
index: ele.index,
Expand All @@ -532,6 +535,7 @@ export function calloutData(values: (ILineChartPoints & { index?: number })[]) {
legend: ele.legend,
y: ele.y,
color: ele.color!,
xAxisCalloutData: ele.xAxisCalloutData,
yAxisCalloutData: ele.yAxisCalloutData,
callOutAccessibilityData: ele.callOutAccessibilityData,
index: ele.index,
Expand Down