Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 16, 2023

Previous Behavior

New Behavior

  1. deprecates getNativeElementProps in favor of getIntrinsicElementProps
  2. updates code generation tools to use getIntrinsicElementProps

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Oct 16, 2023
@bsunderhus
Copy link
Contributor Author

blocked by #29534

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Oct 16, 2023
@bsunderhus bsunderhus marked this pull request as ready for review October 16, 2023 13:13
@bsunderhus bsunderhus requested review from a team as code owners October 16, 2023 13:13
@bsunderhus bsunderhus marked this pull request as draft October 16, 2023 13:14
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 614 650 5000
Button mount 307 320 5000
Field mount 1122 1092 5000
FluentProvider mount 697 730 5000
FluentProviderWithTheme mount 82 85 10
FluentProviderWithTheme virtual-rerender 67 67 10
FluentProviderWithTheme virtual-rerender-with-unmount 76 88 10
InfoButton mount 12 19 5000
MakeStyles mount 844 867 50000
Persona mount 1762 1725 5000
SpinButton mount 1390 1382 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 001c99e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
react-accordion
Accordion (including children components)
93.227 kB
28.402 kB
react-alert
Alert
84.293 kB
23.456 kB
react-avatar
Avatar
50.534 kB
15.923 kB
react-avatar
AvatarGroup
20.064 kB
7.894 kB
react-avatar
AvatarGroupItem
65.19 kB
20.259 kB
react-badge
Badge
27.264 kB
8.808 kB
react-badge
CounterBadge
28.165 kB
9.101 kB
react-badge
PresenceBadge
25.67 kB
9.313 kB
react-button
Button
40.074 kB
11.292 kB
react-button
CompoundButton
47.43 kB
12.787 kB
react-button
MenuButton
44.848 kB
12.668 kB
react-button
SplitButton
52.862 kB
14.254 kB
react-button
ToggleButton
57.122 kB
13.194 kB
react-card
Card - All
93.032 kB
26.934 kB
react-card
Card
87.856 kB
25.435 kB
react-card
CardFooter
13.423 kB
5.481 kB
react-card
CardHeader
15.666 kB
6.235 kB
react-card
CardPreview
14.374 kB
5.854 kB
react-checkbox
Checkbox
37.505 kB
12.327 kB
react-combobox
Combobox (including child components)
91.84 kB
29.937 kB
react-combobox
Dropdown (including child components)
90.282 kB
29.595 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.061 kB
20.164 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.809 kB
59.71 kB
react-components
react-components: FluentProvider & webLightTheme
42.345 kB
13.999 kB
react-datepicker-compat
DatePicker Compat
212.163 kB
59.148 kB
react-dialog
Dialog (including children components)
89.781 kB
26.759 kB
react-divider
Divider
21.179 kB
7.839 kB
react-field
Field
22.788 kB
8.639 kB
react-image
Image
16.096 kB
6.317 kB
react-infobutton
InfoButton
130.581 kB
41.108 kB
react-infobutton
InfoLabel
134.265 kB
42.271 kB
react-input
Input
27.247 kB
9.194 kB
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
react-jsx-runtime
JSX Dev Runtime
4.14 kB
1.741 kB
react-jsx-runtime
JSX Runtime
4.734 kB
1.983 kB
react-label
Label
14.508 kB
5.857 kB
react-link
Link
17.4 kB
6.977 kB
react-menu
Menu (including children components)
140.404 kB
43.358 kB
react-menu
Menu (including selectable components)
143.09 kB
43.871 kB
react-message-bar
MessageBar (all components)
25.54 kB
9.102 kB
react-overflow
hooks only
12.419 kB
4.687 kB
react-persona
Persona
57.425 kB
17.798 kB
react-popover
Popover
119.313 kB
37.636 kB
react-portal
Portal
12.458 kB
4.537 kB
react-portal-compat
PortalCompatProvider
6.706 kB
2.25 kB
react-positioning
usePositioning
25.305 kB
9.162 kB
react-progress
ProgressBar
17.788 kB
6.986 kB
react-provider
FluentProvider
22.89 kB
8.428 kB
react-radio
Radio
31.266 kB
10.267 kB
react-radio
RadioGroup
15.704 kB
6.35 kB
react-select
Select
28.968 kB
10.269 kB
react-slider
Slider
38.349 kB
12.595 kB
react-spinbutton
SpinButton
37.133 kB
11.856 kB
react-spinner
Spinner
23.762 kB
8.556 kB
react-switch
Switch
33.731 kB
10.899 kB
react-table
DataGrid
157.173 kB
43.847 kB
react-table
Table (Primitives only)
44 kB
13.758 kB
react-table
Table as DataGrid
130.468 kB
35.186 kB
react-table
Table (Selection only)
75.836 kB
20.473 kB
react-table
Table (Sort only)
74.443 kB
20.073 kB
react-tags
InteractionTag
15.618 kB
6.152 kB
react-tags
Tag
30.341 kB
9.505 kB
react-tags
TagGroup
74.06 kB
22.091 kB
react-text
Text - Default
17.065 kB
6.645 kB
react-text
Text - Wrappers
20.237 kB
6.965 kB
react-textarea
Textarea
31.306 kB
10.549 kB
react-toast
Toast (including Toaster)
92.681 kB
27.76 kB
react-tooltip
Tooltip
52.525 kB
18.46 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 8794f698cb0617828de5c4a55ca84f9c22147a5b

@size-auditor
Copy link

size-auditor bot commented Oct 16, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4f9b23d13eff25e9dc5f240b4bf607b7600b7c87 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 16, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps branch 2 times, most recently from 869ca16 to d5e8e60 Compare October 16, 2023 13:49
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Oct 16, 2023
@bsunderhus bsunderhus marked this pull request as ready for review October 16, 2023 13:49
@bsunderhus bsunderhus force-pushed the react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps branch from d5e8e60 to 001c99e Compare October 16, 2023 14:11
@bsunderhus bsunderhus merged commit 4dc9e5b into microsoft:master Oct 17, 2023
@bsunderhus bsunderhus deleted the react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps branch October 17, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants