Skip to content

Add ability to add optional css class for checkbox cell #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cschleiden merged 10 commits into from
Sep 28, 2017
Merged

Add ability to add optional css class for checkbox cell #2951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7a55bd7
Added property to IDetailsListProps to support vertically centering c…
Sep 25, 2017
598c3f6
Fixed vertical centering issue with checkbox
Sep 25, 2017
7acf921
Added change file
Sep 25, 2017
b4484b4
Removed verticallyCenterCells
Sep 26, 2017
6faa8b1
Added ability to add css class to checkbox cell
Sep 26, 2017
63f1a52
Fixed issue with DetailsRowProps declaration
Sep 26, 2017
d2eb45d
Changed change file
Sep 26, 2017
bd2218e
Changed name to checkboxCellClassName
Sep 27, 2017
9c0e6aa
Merge branch 'master' into maxlus/verticallyCenterCells
MaxLustig Sep 27, 2017
2f46aea
Update maxlus-verticallyCenterCells_2017-09-26-21-11.json
cschleiden Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/maxlus-verticallyCenterCells_2017-09-26-21-11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: Added ability to add css class to checkbox cell",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
7 changes: 6 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.Props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,11 @@ export interface IDetailsListProps extends React.Props<DetailsList>, IWithViewpo
* The default implementation will virtualize when this callback is not provided.
*/
onShouldVirtualize?: (props: IListProps) => boolean;

/**
* Optional class name to add to the cell of a checkbox
*/
checkboxCellClassName?: string;
}

export interface IColumn {
Expand Down Expand Up @@ -399,4 +404,4 @@ export enum CheckboxVisibility {
* Hide checkboxes.
*/
hidden = 2
}
}
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ export class DetailsList extends BaseComponent<IDetailsListProps, IDetailsListSt
checkboxVisibility,
getRowAriaLabel,
checkButtonAriaLabel,
checkboxCellClassName,
groupProps
} = this.props;
let collapseAllVisibility = groupProps && groupProps.collapseAllVisibility;
Expand Down Expand Up @@ -431,7 +432,8 @@ export class DetailsList extends BaseComponent<IDetailsListProps, IDetailsListSt
checkboxVisibility: checkboxVisibility,
collapseAllVisibility: collapseAllVisibility,
getRowAriaLabel: getRowAriaLabel,
checkButtonAriaLabel: checkButtonAriaLabel
checkButtonAriaLabel: checkButtonAriaLabel,
checkboxCellClassName: checkboxCellClassName,
}, this._onRenderRow);
}

Expand Down
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsRow.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ $detailsList-item-focus-meta-text-color: $ms-color-neutralDark;
}
}


.isPadded {
@include ms-padding-right($isPaddedMargin + $rowHorizontalPadding);

Expand All @@ -230,4 +231,4 @@ $detailsList-item-focus-meta-text-color: $ms-color-neutralDark;
.cellMeasurer .cell {
overflow: visible;
white-space: nowrap;
}
}
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export interface IDetailsRowProps extends React.Props<DetailsRow> {
collapseAllVisibility?: CollapseAllVisibility;
getRowAriaLabel?: (item: any) => string;
checkButtonAriaLabel?: string;
checkboxCellClassName?: string;
}

export interface IDetailsRowSelectionState {
Expand Down Expand Up @@ -184,6 +185,7 @@ export class DetailsRow extends BaseComponent<IDetailsRowProps, IDetailsRowState
checkboxVisibility,
getRowAriaLabel,
checkButtonAriaLabel,
checkboxCellClassName,
selection
} = this.props;
const { columnMeasureInfo, isDropping, groupNestingDepth } = this.state;
Expand Down Expand Up @@ -230,7 +232,7 @@ export class DetailsRow extends BaseComponent<IDetailsRowProps, IDetailsRowState
role='gridcell'
aria-colindex={ 0 }
data-selection-toggle={ true }
className={ css('ms-DetailsRow-cell', 'ms-DetailsRow-cellCheck', checkStyles.owner, styles.cell, styles.checkCell) }
className={ css('ms-DetailsRow-cell', 'ms-DetailsRow-cellCheck', checkStyles.owner, styles.cell, styles.checkCell, checkboxCellClassName) }
>
{ onRenderCheck({
isSelected,
Expand Down
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsRowCheck.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}

button.check {
height: 100%;
height: 40px;
width: 40px;
padding: 0;
margin: 0;
Expand Down