Skip to content

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 11, 2023

New Behavior

Follow up on #29310

getNativeElementProps has some type safety issues, allowing erroneous properties to be introduced.

  1. replaces use cases of getNativeElementProps with an equivalent but more restrict method getIntrinsicElementProps

@bsunderhus bsunderhus self-assigned this Oct 11, 2023
@bsunderhus bsunderhus marked this pull request as ready for review October 11, 2023 16:48
@bsunderhus bsunderhus requested review from a team and marcosmoura as code owners October 11, 2023 16:48
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 11, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-card
Card - All
91.484 kB
26.485 kB
91.553 kB
26.502 kB
69 B
17 B
react-card
Card
86.31 kB
24.946 kB
86.377 kB
24.97 kB
67 B
24 B
react-card
CardFooter
12.074 kB
5.034 kB
12.147 kB
5.058 kB
73 B
24 B
react-card
CardHeader
14.323 kB
5.8 kB
14.39 kB
5.818 kB
67 B
18 B
react-card
CardPreview
13.031 kB
5.404 kB
13.098 kB
5.431 kB
67 B
27 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.351 kB
59.452 kB
207.352 kB
59.451 kB
1 B
-1 B
react-image
Image
14.752 kB
5.875 kB
14.819 kB
5.903 kB
67 B
28 B
react-text
Text - Default
15.766 kB
6.23 kB
15.788 kB
6.231 kB
22 B
1 B
react-text
Text - Wrappers
18.944 kB
6.551 kB
18.961 kB
6.549 kB
17 B
-2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.596 kB
19.874 kB
react-components
react-components: FluentProvider & webLightTheme
40.866 kB
13.546 kB
react-datepicker-compat
DatePicker Compat
210.683 kB
58.707 kB
react-input
Input
25.97 kB
8.77 kB
react-portal-compat
PortalCompatProvider
6.503 kB
2.22 kB
🤖 This report was generated against a55d7d2effa1f991b08d1c4e8335a9abff758f7e

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 11, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 677 632 5000
Button mount 307 313 5000
Field mount 1132 1093 5000
FluentProvider mount 702 697 5000
FluentProviderWithTheme mount 74 82 10
FluentProviderWithTheme virtual-rerender 63 58 10
FluentProviderWithTheme virtual-rerender-with-unmount 71 75 10
InfoButton mount 11 11 5000
MakeStyles mount 851 859 50000
Persona mount 1723 1685 5000
SpinButton mount 1401 1357 5000

@bsunderhus bsunderhus force-pushed the cxe-prg/chore--migrates-from-getNativeElementProps-for-getIntrinsicElementProps branch from 4fe2f52 to be276c3 Compare October 11, 2023 16:57
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit be276c3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Oct 11, 2023

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: bb1c1c7

Possible causes

  • The baseline build bb1c1c7 is broken
  • The Size Auditor run for the baseline build bb1c1c7 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@bsunderhus bsunderhus merged commit 355fd56 into microsoft:master Oct 11, 2023
@bsunderhus bsunderhus deleted the cxe-prg/chore--migrates-from-getNativeElementProps-for-getIntrinsicElementProps branch October 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants