Skip to content

Fixes suggestions not being read out in IE #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dzearing merged 3 commits into from
Sep 26, 2017
Merged

Fixes suggestions not being read out in IE #2944

dzearing merged 3 commits into from
Sep 26, 2017

Conversation

@martellaj
Copy link
Member

@martellaj martellaj commented Sep 25, 2017 •
edited
Loading

Pull request checklist

  • Include a change request file using $ npm run change

Description of changes

  • Currently, the people picker within the share UI doesn't read suggestions as you arrow through when hosted in the Office apps because it doesn't work in IE
  • Investigated and found a solution that mostly works
  • Caveats include: generic suggestion item needing a prop called primaryText or name to generate an ARIA label and slightly different (but acceptable and working) behavior across browsers
  • I'll follow up in email with more discussion and ODB dev links

@dzearing dzearing merged commit 13c14c4 into microsoft:master Sep 26, 2017
kellygorr pushed a commit to kellygorr/office-ui-fabric-react that referenced this pull request Nov 16, 2017
@martellaj @kellygorr
Fixes suggestions not being read out in IE (microsoft#2944)
faa1867 
* Fixes suggestions not being read out in IE

* Adds change file

* Update joem-suggestion-reading_2017-09-26-17-17.json
ohritz pushed a commit to ohritz/office-ui-fabric-react that referenced this pull request Dec 5, 2017
@martellaj @ohritz
Fixes suggestions not being read out in IE (microsoft#2944)
3f55bdd 
* Fixes suggestions not being read out in IE

* Adds change file

* Update joem-suggestion-reading_2017-09-26-17-17.json
@rebeccaballantyne rebeccaballantyne mentioned this pull request May 3, 2018
Merged
2 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dzearing dzearing dzearing approved these changes

@joschect joschect Awaiting requested review from joschect

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martellaj @dzearing @msftclas @msftgits