Skip to content

Remove a11y test ux from v9 Theme Designer #29379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mltejera merged 1 commit into from
Oct 3, 2023
Merged

Remove a11y test ux from v9 Theme Designer #29379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions packages/react-components/theme-designer/src/components/Sidebar/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ import {
Button,
Input,
Slider,
Switch,
tokens,
useId,
Caption1Stronger,
Field,
} from '@fluentui/react-components';
import { defaultThemePlaceholderName } from '../../Context/ThemeDesignerContext';
import { AccessibilityPanel } from './AccessibilityPanel';
// import { AccessibilityPanel } from './AccessibilityPanel';
import { useDebounce } from '../../utils/useDebounce';

const useStyles = makeStyles({
Expand Down Expand Up @@ -89,13 +88,15 @@ export const Form: React.FC = () => {

const {
dispatch,
state: { isDark, themeName, darkThemeOverrides, lightThemeOverrides, brand, keyColorHex },
state: { themeName, keyColorHex },
// - unused values from a11y panel.
// isDark, darkThemeOverrides, lightThemeOverrides, brand,
} = useThemeDesigner();
const themeNameInputId = useId('themeNameInputId');

const handleIsDarkChange = () => {
dispatch({ type: 'isDark', payload: !isDark });
};
// const handleIsDarkChange = () => {
// dispatch({ type: 'isDark', payload: !isDark });
// };

const [keyColor, setKeyColor] = React.useState<string>(keyColorHex);
const [hueTorsion, setHueTorsion] = React.useState<number>(0);
Expand Down Expand Up @@ -221,6 +222,9 @@ export const Form: React.FC = () => {
</div>
</AccordionPanel>
</AccordionItem>
{/*
The accessibility check is not adequate for the theme designer.
Removing it for now because we don't want people proceeding with a false sense of security.
<AccordionItem value="2">
<AccordionHeader>
<Caption1Stronger>Step 2 - Accessibility checks</Caption1Stronger>
Expand All @@ -233,10 +237,10 @@ export const Form: React.FC = () => {
lightThemeOverrides={lightThemeOverrides}
/>
</AccordionPanel>
</AccordionItem>
<AccordionItem value="3">
</AccordionItem> */}
<AccordionItem value="2">
<AccordionHeader>
<Caption1Stronger>Step 3 - Export</Caption1Stronger>
<Caption1Stronger>Step 2 - Export</Caption1Stronger>
</AccordionHeader>
<AccordionPanel className={styles.accordionContainer}>
<div className={styles.labelName}>
Expand Down