Skip to content

Fix 27482: ProgressBar has an optional state variable #29366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeoffCoxMSFT merged 5 commits into from
Oct 3, 2023
Merged

Fix 27482: ProgressBar has an optional state variable #29366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7db8dab
fix: Made ProgressBar slots required in state
GeoffCoxMSFT Oct 2, 2023
98b3c9a
yarn change
GeoffCoxMSFT Oct 2, 2023
3c80b83
Updated API
GeoffCoxMSFT Oct 3, 2023
c31cff9
Merge branch 'master' into fix-27482
GeoffCoxMSFT Oct 3, 2023
c51ce62
Merge branch 'master' into fix-27482
GeoffCoxMSFT Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-progress-6ff752f2-0a52-4f4e-b70b-8cfe2699ee3c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Updated slots to be required in ProgressBarState",
"packageName": "@fluentui/react-progress",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-progress/etc/react-progress.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export type ProgressBarSlots = {
};

// @public
export type ProgressBarState = ComponentState<ProgressBarSlots> & Required<Pick<ProgressBarProps, 'max' | 'shape' | 'thickness'>> & Pick<ProgressBarProps, 'value' | 'color'>;
export type ProgressBarState = ComponentState<Required<ProgressBarSlots>> & Required<Pick<ProgressBarProps, 'max' | 'shape' | 'thickness'>> & Pick<ProgressBarProps, 'value' | 'color'>;

// @public
export const renderProgressBar_unstable: (state: ProgressBarState) => JSX.Element;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-progress/src/components/ProgressBar/ProgressBar.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ export type ProgressBarProps = Omit<ComponentProps<ProgressBarSlots>, 'size'> &
/**
* State used in rendering ProgressBar
*/
export type ProgressBarState = ComponentState<ProgressBarSlots> &
export type ProgressBarState = ComponentState<Required<ProgressBarSlots>> &
Required<Pick<ProgressBarProps, 'max' | 'shape' | 'thickness'>> &
Pick<ProgressBarProps, 'value' | 'color'>;