Fixing the issue Going from stack callout to single callout and back to stack callout still shows the single callout #29324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report🤖 This report was generated against 1c0919a13a533014b70d6da64500f6bfe2ff14b3 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a175330:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1c0919a13a533014b70d6da64500f6bfe2ff14b3 (build) |
AtishayMsft
reviewed
Sep 29, 2023
packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Oct 4, 2023
change/@fluentui-react-charting-e365c5ce-592e-422f-9329-1bee461a0dc3.json
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Oct 4, 2023
packages/react-charting/src/components/VerticalStackedBarChart/VerticalStackedBarChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
approved these changes
Oct 4, 2023
…ck to stack callout still shows the single callout
…from the first instance where the callout was shown
fabricteam
reviewed
Oct 5, 2023
change/@fluentui-react-charting-e365c5ce-592e-422f-9329-1bee461a0dc3.json
Show resolved
Hide resolved
AtishayMsft
approved these changes
Oct 5, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 5, 2023
* master: fix: screenreader narration improvements (microsoft#29404) chore: Adds VR tests for MessageBar (microsoft#29405) Fixing the issue Going from stack callout to single callout and back to stack callout still shows the single callout (microsoft#29324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ck to stack callout still shows the single callout
Previous Behavior
The single callout/stack callout radio button behavior is not consistent.
Going from stack callout to single callout and back to stack callout still shows the single callout.
New Behavior
Shows the correct callout on going back to single to stack callout
Related Issue(s)