fix: Context menu close should restore focus #29290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression from microsoft#28530 The `contextMenuProps` aren't really for just the context menu but common props for all menus fter the refactor in microsoft#25044. We should probably revisit the menu trigger code and clean it up but this fix is more urgent
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b92fd5d:
|
bsunderhus
reviewed
Sep 26, 2023
packages/react-components/react-menu/stories/Menu/MenuDefault.stories.tsx
Show resolved
Hide resolved
bsunderhus
approved these changes
Sep 26, 2023
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 12 | 12 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 642 | 656 | 5000 | |
| Button | mount | 331 | 333 | 5000 | |
| Field | mount | 1156 | 1125 | 5000 | |
| FluentProvider | mount | 721 | 711 | 5000 | |
| FluentProviderWithTheme | mount | 95 | 116 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 80 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 93 | 99 | 10 | |
| InfoButton | mount | 12 | 12 | 5000 | Possible regression |
| MakeStyles | mount | 869 | 873 | 50000 | |
| Persona | mount | 1877 | 1751 | 5000 | |
| SpinButton | mount | 1457 | 1440 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b11ab1c1968c8317cb6262b6c5f51cf6d41662fe (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression from #28530
The
contextMenuPropsaren't really for just the context menu but common props for all menus fter therefactor in #25044. We should probably revisit the menu trigger code and clean it up but this fix is more urgent