feat(react-drawer): dialog slot to be only used by internal composition API #29279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 322eb4b:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 15 | 14 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 615 | 655 | 5000 | |
| Button | mount | 302 | 294 | 5000 | |
| Field | mount | 1102 | 1124 | 5000 | |
| FluentProvider | mount | 696 | 691 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 75 | 10 | |
| InfoButton | mount | 15 | 14 | 5000 | Possible regression |
| MakeStyles | mount | 860 | 865 | 50000 | |
| Persona | mount | 1723 | 1709 | 5000 | |
| SpinButton | mount | 1405 | 1378 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c1ae0fb42575ae2deb11b32110538adbd0f652ad (build) |
| "comment": "feat: make dialog slot internal to be used for composition only", | ||
| "packageName": "@fluentui/react-drawer", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" |
Contributor
There was a problem hiding this comment.
Don't forget to update in to feature
ValentinaKozlova
approved these changes
Sep 29, 2023
Contributor
Author
|
This PR is not needed as #29392 now have all of these changes. |
marcosmoura
deleted the
feat/react-drawer/make-dialog-slot-internal-to-composition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Dialog was created as an external slot and users could easily override to any other component with the same signature. That could lead to a completely broken Drawer as it is heavily dependent on Dialog.
New Behavior
Makes the Dialog as an internal slot. That makes it possible to override the Dialog component only when explicitly using the composition API.