feat(react-tabster): adds customizeSelector to createCustomFocusIndicatorStyle method
#29209
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 614 | 643 | 5000 | |
| Button | mount | 326 | 310 | 5000 | |
| Field | mount | 1121 | 1104 | 5000 | |
| FluentProvider | mount | 682 | 685 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 76 | 10 | |
| InfoButton | mount | 6 | 13 | 5000 | |
| MakeStyles | mount | 861 | 866 | 50000 | |
| Persona | mount | 1715 | 1661 | 5000 | |
| SpinButton | mount | 1341 | 1329 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e33852b:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: aef09fc324e71a15a10a6a3c1c7ed556e2775725 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Member
|
Can you please share CSS that needs to be generated? As I see, it's not really needed: |
Contributor
Author
Problem here is the order, in the case of the TreeItem I'd use a children selector + attribute selector, it won't be equivalent |
layershifter
approved these changes
Sep 21, 2023
bsunderhus
force-pushed
the
react-tabster/feat--adds-suffixes-to-selectors-for-createCustomFocusIndicatorStyle
branch
from
23e4dd1 to
2aeeb26
Compare
bsunderhus
force-pushed
the
react-tabster/feat--adds-suffixes-to-selectors-for-createCustomFocusIndicatorStyle
branch
from
2aeeb26 to
e33852b
Compare
bsunderhus
changed the title
customizeSelector to createCustomFocusIndicatorStyle method
ling1726
approved these changes
Sep 26, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 26, 2023
* master: fix(react-dialog): use makeResetStyles for base dialog components styles (microsoft#29280) chore(react-tags-preview): update props descriptions (microsoft#29287) chore: bump swc core to mitigate transpilation memory leaks (microsoft#29253) feat: adds customizeSelector to createCustomFocusIndicatorStyle method (microsoft#29209) applying package updates Updated TooltipBestPractices to include accessibility best practices (microsoft#29284) fix: BreadcrumbItem should use makeResetStyles for base styles (microsoft#29278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
At the moment there's no way to modify the selector internally used to indicate if an element is focused.
New Behavior
customizeSelectormethod to allow the customization of the selector of focus stylesThis allows the customization of the selector, allowing ,for example, the possibility of selecting a different element on the focusing of a given element.
This is useful for the use case of
TreeItemandTreeItemLayout, where the focused element will be theTreeItembut the outline would be better positioned if it was visible relative to theTreeItemLayoutelement inside ofTreeItem