chore: remove @swc/helpers version pin for codesandbox #29191

YuanboXue-Amber · 2023-09-20T11:33:40Z

We pin @swc/helpers in codesandbox in #29016 because of dependency issue in @swc 0.4.x versions. Now that #28919 is completed and @swc/helpers is on 0.5.x, this version pin can be removed

codesandbox-ci · 2023-09-20T11:46:02Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 484ada7:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

YuanboXue-Amber · 2023-09-20T14:09:50Z

/azp run

azure-pipelines · 2023-09-20T14:10:16Z

Azure Pipelines successfully started running 4 pipeline(s).

fabricteam · 2023-09-21T08:23:21Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
InfoButton	mount	18	14	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	610	632	5000
Button	mount	321	317	5000
Field	mount	1109	1096	5000
FluentProvider	mount	692	701	5000
FluentProviderWithTheme	mount	77	85	10
FluentProviderWithTheme	virtual-rerender	62	64	10
FluentProviderWithTheme	virtual-rerender-with-unmount	75	76	10
InfoButton	mount	18	14	5000	Possible regression
MakeStyles	mount	850	855	50000
Persona	mount	1764	1659	5000
SpinButton	mount	1403	1377	5000

fabricteam · 2023-09-21T08:23:53Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	95	85	1.12:1
AccordionMinimalPerf.default	85	78	1.09:1
ChatDuplicateMessagesPerf.default	147	135	1.09:1
DividerMinimalPerf.default	211	194	1.09:1
GridMinimalPerf.default	189	179	1.06:1
MenuMinimalPerf.default	520	491	1.06:1
TooltipMinimalPerf.default	1293	1219	1.06:1
HeaderMinimalPerf.default	203	194	1.05:1
StatusMinimalPerf.default	400	380	1.05:1
TextAreaMinimalPerf.default	293	280	1.05:1
AttachmentSlotsPerf.default	646	621	1.04:1
RadioGroupMinimalPerf.default	264	254	1.04:1
ButtonSlotsPerf.default	319	309	1.03:1
DropdownManyItemsPerf.default	388	377	1.03:1
FormMinimalPerf.default	218	211	1.03:1
InputMinimalPerf.default	530	516	1.03:1
LabelMinimalPerf.default	221	214	1.03:1
ListNestedPerf.default	326	316	1.03:1
SegmentMinimalPerf.default	197	192	1.03:1
SkeletonMinimalPerf.default	200	195	1.03:1
IconMinimalPerf.default	397	387	1.03:1
CustomToolbarPrototype.default	1489	1448	1.03:1
TreeMinimalPerf.default	466	454	1.03:1
DropdownMinimalPerf.default	1437	1403	1.02:1
ListCommonPerf.default	383	377	1.02:1
ProviderMinimalPerf.default	196	193	1.02:1
TableManyItemsPerf.default	1094	1075	1.02:1
ButtonMinimalPerf.default	85	84	1.01:1
ButtonOverridesMissPerf.default	642	633	1.01:1
CarouselMinimalPerf.default	253	251	1.01:1
DatepickerMinimalPerf.default	3522	3479	1.01:1
DialogMinimalPerf.default	431	427	1.01:1
PopupMinimalPerf.default	346	343	1.01:1
CheckboxMinimalPerf.default	1122	1121	1:1
EmbedMinimalPerf.default	1830	1829	1:1
FlexMinimalPerf.default	154	154	1:1
HeaderSlotsPerf.default	447	445	1:1
ListMinimalPerf.default	303	304	1:1
ReactionMinimalPerf.default	206	206	1:1
TableMinimalPerf.default	236	235	1:1
AttachmentMinimalPerf.default	75	76	0.99:1
BoxMinimalPerf.default	192	194	0.99:1
CardMinimalPerf.default	291	295	0.99:1
ChatWithPopoverPerf.default	191	193	0.99:1
ItemLayoutMinimalPerf.default	692	701	0.99:1
PortalMinimalPerf.default	84	85	0.99:1
RefMinimalPerf.default	107	108	0.99:1
SplitButtonMinimalPerf.default	2185	2203	0.99:1
AnimationMinimalPerf.default	290	295	0.98:1
ChatMinimalPerf.default	414	423	0.98:1
LayoutMinimalPerf.default	193	196	0.98:1
RosterPerf.default	1503	1532	0.98:1
ProviderMergeThemesPerf.default	624	635	0.98:1
ToolbarMinimalPerf.default	527	537	0.98:1
AlertMinimalPerf.default	153	157	0.97:1
LoaderMinimalPerf.default	186	191	0.97:1
SliderMinimalPerf.default	734	753	0.97:1
VideoMinimalPerf.default	422	434	0.97:1
ImageMinimalPerf.default	225	234	0.96:1
ListWith60ListItems.default	347	362	0.96:1
MenuButtonMinimalPerf.default	935	971	0.96:1
TextMinimalPerf.default	188	199	0.94:1
AvatarMinimalPerf.default	101	120	0.84:1

fabricteam · 2023-09-21T08:25:03Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-09-21T08:29:33Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-09-21T08:30:33Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.162 kB` `1.735 kB`
`react-accordion` Accordion (including children components)	`91.583 kB` `27.954 kB`
`react-alert` Alert	`83.657 kB` `22.895 kB`
`react-avatar` Avatar	`49.035 kB` `15.434 kB`
`react-avatar` AvatarGroup	`18.782 kB` `7.48 kB`
`react-avatar` AvatarGroupItem	`63.687 kB` `19.786 kB`
`react-badge` Badge	`25.987 kB` `8.384 kB`
`react-badge` CounterBadge	`26.888 kB` `8.687 kB`
`react-badge` PresenceBadge	`24.046 kB` `8.762 kB`
`react-button` Button	`39.667 kB` `10.794 kB`
`react-button` CompoundButton	`47.023 kB` `12.295 kB`
`react-button` MenuButton	`44.094 kB` `12.056 kB`
`react-button` SplitButton	`52.12 kB` `13.632 kB`
`react-button` ToggleButton	`56.756 kB` `12.702 kB`
`react-card` Card - All	`91.443 kB` `26.437 kB`
`react-card` Card	`86.232 kB` `24.895 kB`
`react-card` CardFooter	`12.14 kB` `5.061 kB`
`react-card` CardHeader	`14.431 kB` `5.832 kB`
`react-card` CardPreview	`13.097 kB` `5.434 kB`
`react-checkbox` Checkbox	`35.808 kB` `11.802 kB`
`react-combobox` Combobox (including child components)	`90.577 kB` `29.554 kB`
`react-combobox` Dropdown (including child components)	`88.932 kB` `29.201 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.572 kB` `19.658 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`208.392 kB` `59.385 kB`
`react-components` react-components: FluentProvider & webLightTheme	`40.966 kB` `13.569 kB`
`react-datepicker-compat` DatePicker Compat	`211.639 kB` `58.838 kB`
`react-dialog` Dialog (including children components)	`90.125 kB` `27.485 kB`
`react-divider` Divider	`19.902 kB` `7.415 kB`
`react-field` Field	`21.234 kB` `8.128 kB`
`react-image` Image	`14.818 kB` `5.902 kB`
`react-infobutton` InfoButton	`129.801 kB` `40.756 kB`
`react-infobutton` InfoLabel	`133.534 kB` `41.945 kB`
`react-input` Input	`26.143 kB` `8.844 kB`
`react-jsx-runtime` Classic Pragma	`1.072 kB` `544 B`
`react-jsx-runtime` JSX Dev Runtime	`2.893 kB` `1.319 kB`
`react-jsx-runtime` JSX Runtime	`3.479 kB` `1.554 kB`
`react-label` Label	`13.225 kB` `5.438 kB`
`react-link` Link	`16.095 kB` `6.53 kB`
`react-menu` Menu (including children components)	`139.823 kB` `43.055 kB`
`react-menu` Menu (including selectable components)	`142.559 kB` `43.576 kB`
`react-overflow` hooks only	`12.594 kB` `4.702 kB`
`react-persona` Persona	`55.926 kB` `17.314 kB`
`react-popover` Popover	`118.895 kB` `37.406 kB`
`react-portal` Portal	`12.362 kB` `4.543 kB`
`react-portal-compat` PortalCompatProvider	`6.541 kB` `2.227 kB`
`react-positioning` usePositioning	`25.245 kB` `9.141 kB`
`react-progress` ProgressBar	`16.598 kB` `6.608 kB`
`react-provider` FluentProvider	`21.511 kB` `7.994 kB`
`react-radio` Radio	`29.517 kB` `9.732 kB`
`react-radio` RadioGroup	`14.543 kB` `5.985 kB`
`react-select` Select	`27.518 kB` `9.804 kB`
`react-slider` Slider	`37.043 kB` `12.203 kB`
`react-spinbutton` SpinButton	`35.724 kB` `11.399 kB`
`react-spinner` Spinner	`22.481 kB` `8.146 kB`
`react-switch` Switch	`32.079 kB` `10.39 kB`
`react-table` DataGrid	`156.606 kB` `43.603 kB`
`react-table` Table (Primitives only)	`42.651 kB` `13.28 kB`
`react-table` Table as DataGrid	`129.472 kB` `34.761 kB`
`react-table` Table (Selection only)	`74.748 kB` `20.076 kB`
`react-table` Table (Sort only)	`73.379 kB` `19.672 kB`
`react-tags-preview` InteractionTag	`14.038 kB` `5.658 kB`
`react-tags-preview` Tag	`29.806 kB` `9.597 kB`
`react-tags-preview` TagGroup	`72.687 kB` `21.648 kB`
`react-text` Text - Default	`15.832 kB` `6.254 kB`
`react-text` Text - Wrappers	`19.01 kB` `6.578 kB`
`react-textarea` Textarea	`30.203 kB` `10.199 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`91.789 kB` `27.423 kB`
`react-tooltip` Tooltip	`51.348 kB` `18.113 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 81d629fbc7206dab2bc2dd4878487a079601f396}

size-auditor · 2023-09-21T08:32:05Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 81d629fbc7206dab2bc2dd4878487a079601f396 (build)

fabricteam · 2023-09-21T08:33:25Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-09-21T08:33:58Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	624	626	5000
Breadcrumb	mount	1687	1666	1000
Checkbox	mount	1688	1683	5000
CheckboxBase	mount	1471	1473	5000
ChoiceGroup	mount	2876	2880	5000
ComboBox	mount	662	671	1000
CommandBar	mount	6144	6128	1000
ContextualMenu	mount	12188	12092	1000
DefaultButton	mount	758	758	5000
DetailsRow	mount	2172	2135	5000
DetailsRowFast	mount	2124	2209	5000
DetailsRowNoStyles	mount	1996	1987	5000
Dialog	mount	2622	2634	1000
DocumentCardTitle	mount	239	231	1000
Dropdown	mount	1924	1959	5000
FocusTrapZone	mount	1103	1130	5000
FocusZone	mount	1054	1037	5000
GroupedList	mount	41008	40932	2
GroupedList	virtual-rerender	19924	19751	2
GroupedList	virtual-rerender-with-unmount	50991	50316	2
GroupedListV2	mount	223	227	2
GroupedListV2	virtual-rerender	205	207	2
GroupedListV2	virtual-rerender-with-unmount	232	230	2
IconButton	mount	1065	1072	5000
Label	mount	341	341	5000
Layer	mount	2698	2734	5000
Link	mount	391	379	5000
MenuButton	mount	941	945	5000
MessageBar	mount	21440	21468	5000
Nav	mount	1936	1988	1000
OverflowSet	mount	792	769	5000
Panel	mount	1838	1746	1000
Persona	mount	728	752	1000
Pivot	mount	836	873	1000
PrimaryButton	mount	841	832	5000
Rating	mount	4541	4629	5000
SearchBox	mount	892	910	5000
Shimmer	mount	1859	1838	5000
Slider	mount	1285	1289	5000
SpinButton	mount	2839	2895	5000
Spinner	mount	394	385	5000
SplitButton	mount	1815	1800	5000
Stack	mount	404	412	5000
StackWithIntrinsicChildren	mount	864	848	5000
StackWithTextChildren	mount	2632	2562	5000
SwatchColorPicker	mount	5996	6113	5000
TagPicker	mount	1475	1461	5000
Text	mount	371	377	5000
TextField	mount	926	930	5000
ThemeProvider	mount	836	808	5000
ThemeProvider	virtual-rerender	579	576	5000
ThemeProvider	virtual-rerender-with-unmount	1286	1281	5000
Toggle	mount	605	618	5000
buttonNative	mount	189	186	5000

fix

e692382

Merge branch 'master' into cleanupswc

484ada7

YuanboXue-Amber marked this pull request as ready for review September 21, 2023 08:45

YuanboXue-Amber requested a review from a team as a code owner September 21, 2023 08:45

YuanboXue-Amber enabled auto-merge (squash) September 21, 2023 09:17

ling1726 approved these changes Sep 21, 2023

View reviewed changes

YuanboXue-Amber merged commit 8cc839b into microsoft:master Sep 21, 2023

YuanboXue-Amber deleted the cleanupswc branch September 21, 2023 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove @swc/helpers version pin for codesandbox #29191

chore: remove @swc/helpers version pin for codesandbox #29191

Uh oh!

YuanboXue-Amber commented Sep 20, 2023

Uh oh!

codesandbox-ci bot commented Sep 20, 2023 •

edited

Loading

Uh oh!

YuanboXue-Amber commented Sep 20, 2023

Uh oh!

azure-pipelines bot commented Sep 20, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

size-auditor bot commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: remove @swc/helpers version pin for codesandbox #29191

chore: remove @swc/helpers version pin for codesandbox #29191

Uh oh!

Conversation

YuanboXue-Amber commented Sep 20, 2023

Uh oh!

codesandbox-ci bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YuanboXue-Amber commented Sep 20, 2023

Uh oh!

azure-pipelines bot commented Sep 20, 2023

Uh oh!

fabricteam commented Sep 21, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Sep 21, 2023

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Sep 21, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented Sep 21, 2023

🕵 FluentUIV0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Sep 21, 2023

📊 Bundle size report

Uh oh!

size-auditor bot commented Sep 21, 2023

Asset size changes

Uh oh!

fabricteam commented Sep 21, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Sep 21, 2023

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codesandbox-ci bot commented Sep 20, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)