Skip to content

feat(react-tree): flat tree supports navigation without useHeadlessFlatTree #29091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsunderhus merged 1 commit into from
Sep 25, 2023
Merged

feat(react-tree): flat tree supports navigation without useHeadlessFlatTree #29091

bsunderhus merged 1 commit into from
Sep 25, 2023

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Sep 7, 2023 •
edited
Loading

New Behavior

  1. implements navigation on FlatTree component
  2. implements opt-out mechanism to internal navigation
    • to opt-out prevent default on the event that causes navigation
  3. adds story for using FlatTree without useHeadlessFlatTree

@bsunderhus bsunderhus self-assigned this Sep 7, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 649 650 5000
Button mount 323 318 5000
Field mount 1112 1153 5000
FluentProvider mount 711 720 5000
FluentProviderWithTheme mount 88 100 10
FluentProviderWithTheme virtual-rerender 69 73 10
FluentProviderWithTheme virtual-rerender-with-unmount 87 83 10
InfoButton mount 13 14 5000
MakeStyles mount 892 884 50000
Persona mount 1774 1723 5000
SpinButton mount 1410 1479 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.572 kB
19.658 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 208.688 kB
59.552 kB
react-components
react-components: FluentProvider & webLightTheme		 40.966 kB
13.569 kB
react-portal-compat
PortalCompatProvider		 6.541 kB
2.227 kB
🤖 This report was generated against a56c408d4ed860a48e22780289e5c4a00ebec6c4

@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch from 4d975b2 to c8c42af Compare September 7, 2023 08:58
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c727d6b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 7, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a56c408d4ed860a48e22780289e5c4a00ebec6c4 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 7, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch 6 times, most recently from 0d65ba2 to 57193a2 Compare September 7, 2023 12:00
@bsunderhus bsunderhus marked this pull request as ready for review September 7, 2023 12:11
@bsunderhus bsunderhus requested review from a team as code owners September 7, 2023 12:11
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch 5 times, most recently from f7575f0 to 332b380 Compare September 7, 2023 15:50
@bsunderhus bsunderhus changed the title React-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree feat(react-tree): flat tree supports navigation without useHeadlessFlatTree Sep 18, 2023
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch 2 times, most recently from bce25b1 to 9b15406 Compare September 20, 2023 07:31
@bsunderhus bsunderhus marked this pull request as draft September 20, 2023 09:45
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch 2 times, most recently from 879a5af to a278d28 Compare September 21, 2023 07:23
@bsunderhus bsunderhus marked this pull request as ready for review September 21, 2023 07:24
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch 2 times, most recently from f655e77 to 6e86c41 Compare September 21, 2023 08:45
@bsunderhus bsunderhus mentioned this pull request Sep 21, 2023
Closed
@bsunderhus bsunderhus marked this pull request as draft September 21, 2023 15:37
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch from 6e8946e to 2809656 Compare September 22, 2023 07:27
@bsunderhus bsunderhus marked this pull request as ready for review September 22, 2023 12:17
@bsunderhus bsunderhus requested a review from ling1726 September 22, 2023 12:32
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch from 2809656 to 2e0b8c3 Compare September 25, 2023 08:43
layershifter
layershifter approved these changes Sep 25, 2023
View reviewed changes
@bsunderhus bsunderhus force-pushed the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch from 2e0b8c3 to c727d6b Compare September 25, 2023 13:05
@bsunderhus bsunderhus merged commit aef09fc into microsoft:master Sep 25, 2023
@bsunderhus bsunderhus deleted the react-tree/feat--flat-tree-supports-navigation-without-useHeadlessFlatTree branch September 25, 2023 14:05
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 25, 2023
@marcosmoura
Merge branch 'master' into feat/react-drawer/make-dialog-slot-interna…
368edcb 
…l-to-composition

* master:
  feat: FlatTree supports navigation without useHeadlessFlatTree (microsoft#29091)
  fix(react-card): sync controllable state for selectable cards (microsoft#29276)
  fix (microsoft#29275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

@ling1726 ling1726 Awaiting requested review from ling1726

Assignees

@bsunderhus bsunderhus

Labels

Component: Tree Fluent UI react-components (v9)

Projects

None yet

Milestone

September Project Cycle Q4 2023

Development

Successfully merging this pull request may close these issues.

4 participants

@bsunderhus @fabricteam @layershifter @ling1726