feat: adds mountNode to DialogSurface and Toaster API #29003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
changed the title
packages/react-components/react-dialog/src/components/DialogSurface/DialogSurface.types.ts
Outdated
Show resolved
Hide resolved
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 634 | 658 | 5000 | |
| Button | mount | 324 | 317 | 5000 | |
| Field | mount | 1111 | 1114 | 5000 | |
| FluentProvider | mount | 696 | 708 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 75 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 83 | 10 | |
| InfoButton | mount | 11 | 12 | 5000 | |
| MakeStyles | mount | 861 | 904 | 50000 | |
| Persona | mount | 1721 | 1680 | 5000 | |
| SpinButton | mount | 1387 | 1345 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fcd2408:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ecaa08385bb0e25eafe87e3fb4424cb9139eea2d (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-dialog/feat--adds-mountNode-to-DialogSurface-API
branch
from
def1656 to
fcd2408
Compare
layershifter
approved these changes
Aug 29, 2023
bsunderhus
deleted the
react-dialog/feat--adds-mountNode-to-DialogSurface-API
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 29, 2023
* master: applying package updates feat: release react-motion as preview (microsoft#29005) fix(react-utilities): click scrollbar should invoke callback in `useOnClickOutside` (microsoft#28965) feat: adds mountNode to DialogSurface and Toaster (microsoft#29003) applying package updates Add IconDirectionProvider to FluentProvider (microsoft#28803)
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Follow up on #28865 for
DialogSurfaceandToasterAPI.Related Issue(s)