Skip to content

chore(react-nav-preview): migrates to use new slot API #28917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Aug 22, 2023
Merged

chore(react-nav-preview): migrates to use new slot API #28917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-components/react-nav-preview/src/components/Nav/renderNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
/** @jsx createElement */

import { createElement } from '@fluentui/react-jsx-runtime';
import { getSlotsNext } from '@fluentui/react-utilities';
import { assertSlots } from '@fluentui/react-utilities';
import type { NavState, NavSlots } from './Nav.types';

/**
* Render the final JSX of Nav
*/
export const renderNav_unstable = (state: NavState) => {
const { slots, slotProps } = getSlotsNext<NavSlots>(state);
assertSlots<NavSlots>(state);

// TODO Add additional slots in the appropriate place
return <slots.root {...slotProps.root} />;
return <state.root />;
};
13 changes: 8 additions & 5 deletions packages/react-components/react-nav-preview/src/components/Nav/useNav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { getNativeElementProps } from '@fluentui/react-utilities';
import { getNativeElementProps, slot } from '@fluentui/react-utilities';
import type { NavProps, NavState } from './Nav.types';

/**
Expand All @@ -20,9 +20,12 @@ export const useNav_unstable = (props: NavProps, ref: React.Ref<HTMLElement>): N
},
// TODO add appropriate slots, for example:
// mySlot: resolveShorthand(props.mySlot),
root: getNativeElementProps('div', {
ref,
...props,
}),
root: slot.always(
getNativeElementProps('div', {
ref,
...props,
}),
{ elementType: 'div' },
),
};
};