fix(react-infobutton): Popover should close when tabbing out of the surface #28913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopranopillow
commented
Aug 18, 2023
change/@fluentui-react-infobutton-e6d4cef7-a090-4513-ac13-c1754d642d63.json
Show resolved
Hide resolved
…to infobutton/dismiss-on-blur
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 644 | 5000 | |
| Button | mount | 318 | 309 | 5000 | |
| Field | mount | 1113 | 1099 | 5000 | |
| FluentProvider | mount | 718 | 711 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 69 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 74 | 10 | |
| InfoButton | mount | 9 | 15 | 5000 | |
| MakeStyles | mount | 836 | 876 | 50000 | |
| Persona | mount | 1709 | 1696 | 5000 | |
| SpinButton | mount | 1327 | 1399 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
reviewed
Aug 24, 2023
packages/react-components/react-infobutton/src/components/InfoButton/useInfoButton.tsx
Outdated
Show resolved
Hide resolved
…to infobutton/dismiss-on-blur
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e2a7a64:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bb8a191dbdd562a2ef077c1bd5fa3dbfd00f0fdf (build) |
mltejera
approved these changes
Sep 7, 2023
Contributor
mltejera
left a comment
mltejera
left a comment
There was a problem hiding this comment.
Nicely done sir! Tested and works as I'd expect :-)
micahgodbolt
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The popover's surface stays open when focus moves out of it.
New Behavior
When tabbing out of the surface, the popover closes.