7.0 Details list row focus contrast a11y bug fix #28781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f27fbe0:
|
Contributor
Author
|
Cherry picking into 8.0 now |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 813c4742a3c3605f640cdb2cd39ab22b0b154a2c (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
|
Collaborator
🕵 FluentUIV7 No visual regressions between this PR and main |
Contributor
Author
|
Merge was delayed because of a failed check that Fluent removed from 8 but left on 7, that check has now been removed from the 7.0 branch as well. |
Jacqueline-ms
added a commit
that referenced
this pull request
Aug 23, 2023
Jacqueline-ms
added a commit
that referenced
this pull request
Aug 23, 2023
* Cherry picked from #28781 * Create @fluentui-azure-themes-cfae358f-02a7-46ba-8e4d-ee45180e9eb8.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When unselected or selected row is tabbed into (focus state) the contrast ratio did not pass accessibility standards of 3:1. Bug states: "Luminosity ratio of the focus boundary around the "rule id row" is 1.2:1 which is less than 3:1 under "Edit Exclusion" page."
Note: light theme fix only. Other themes unaffected
New Behavior
Design team concluded that aligning to what is live on Fluent site is best, which is #605E5C
Source: https://developer.microsoft.com/en-us/fluentui#/controls/web/detailslist/compact