Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: autoSize causing maximum positioning update",
"packageName": "@fluentui/react-positioning",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import { Platform, computePosition } from '@floating-ui/dom';
import { resetMaxSize } from './maxSize';

const referenceRect: Partial<DOMRect> = { x: 0, y: 0, width: 100, height: 100 };
const floatingRect: Partial<DOMRect> = { x: 0, y: 0, width: 50, height: 50 };
const mockGetElementRects = jest.fn(() =>
Promise.resolve({
reference: referenceRect,
floating: floatingRect,
}),
);
const platform = {
getElementRects: mockGetElementRects,
} as Partial<Platform> as Platform;

describe('maxSize', () => {
it('resetMaxSize reset once per life cycle', async () => {
expect.hasAssertions();
const button = document.createElement('div');
const tooltip = document.createElement('div');
const autoSize = { applyMaxHeight: true, applyMaxWidth: true };

await computePosition(button, tooltip, {
placement: 'right',
middleware: [resetMaxSize(autoSize)],
platform,
});
expect(mockGetElementRects).toHaveBeenCalledTimes(2);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export interface MaxSizeMiddlewareOptions extends Pick<PositioningOptions, 'over
*/
export const resetMaxSize = (autoSize: NormalizedAutoSize): Middleware => ({
name: 'resetMaxSize',
fn({ middlewareData: { maxSizeAlreadyReset }, elements }) {
if (maxSizeAlreadyReset) {
fn({ middlewareData, elements }) {
if (middlewareData.resetMaxSize?.maxSizeAlreadyReset) {
return {};
}

Expand Down