Skip to content

fix: remove margin from icon when ToolbarButton is vertical #28658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chpalac merged 2 commits into from
Jul 27, 2023
Merged

fix: remove margin from icon when ToolbarButton is vertical #28658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba9668c
fix: remove margin from icon when ToolbarButton is vertical
chpalac Jul 27, 2023
32a2eb3
chore: add changes
chpalac Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-toolbar-d17fdf5d-7561-468e-b616-f1bbe8f690d5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Remove margin from Icon in ToolbarButton when vertical prop is passed",
"packageName": "@fluentui/react-toolbar",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion ...ct-components/react-toolbar/src/components/ToolbarButton/useToolbarButtonStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { makeStyles, mergeClasses } from '@griffel/react';
import { makeStyles, mergeClasses, shorthands } from '@griffel/react';
import { useButtonStyles_unstable } from '@fluentui/react-button';
import { ToolbarButtonState } from './ToolbarButton.types';

Expand All @@ -8,6 +8,7 @@ const useBaseStyles = makeStyles({
},
verticalIcon: {
fontSize: '24px',
...shorthands.margin('0'),
},
});

Expand Down