Skip to content

fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus #28613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 6 commits into from
Aug 23, 2023
Merged

fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus #28613

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce1b7cc
fix: Only apply modal attributes if the PopoverSurface traps focus.
sopranopillow Jul 21, 2023
969d719
change file
sopranopillow Jul 21, 2023
99bebc5
Merge branch 'master' of https://github.com/microsoft/fluentui into p…
sopranopillow Aug 14, 2023
905aca5
update snapshot
sopranopillow Aug 14, 2023
390c1d2
revert charting changes
sopranopillow Aug 14, 2023
30b727c
Merge branch 'master' into popover-trapfocus-modal
sopranopillow Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-popover-fe679067-7ac1-4e5f-84bc-528f6f0d3865.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus.",
"packageName": "@fluentui/react-popover",
"email": "esteban.230@hotmail.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-popover/src/components/PopoverSurface/usePopoverSurface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const usePopoverSurface_unstable = (
ref: useMergedRefs(ref, contentRef),
role: trapFocus ? 'dialog' : 'group',
'aria-modal': trapFocus ? true : undefined,
...modalAttributes,
...(trapFocus ? modalAttributes : {}),
Comment thread
ling1726 marked this conversation as resolved.
Outdated
...props,
}),
};
Expand Down