Skip to content

28576 small button is using 3px border radius #28589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 6 commits into from
Aug 25, 2023
Merged

28576 small button is using 3px border radius #28589

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fea71db
#28576: [Bug]: Small <Button> is using 3px border radius
AbdulRehmanMehar Jul 19, 2023
e26e712
run yarn change
AbdulRehmanMehar Jul 19, 2023
b9c74be
Merge branch 'master' into 28576-Small-Button-is-using-3px-border-radius
AbdulRehmanMehar Jul 19, 2023
78bf80f
updated the code to use token for border-radius
AbdulRehmanMehar Jul 21, 2023
915e377
updated the comment as per @sopranopillow's suggestion
AbdulRehmanMehar Aug 24, 2023
26aa4b6
Merge branch 'master' into 28576-Small-Button-is-using-3px-border-radius
AbdulRehmanMehar Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-button-a033d25e-6861-40b4-a52e-eb4632568acb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
sopranopillow marked this conversation as resolved.
"type": "patch",
"comment": "#28576: [Bug]: Small <Button> is using 3px border radius",
Comment thread
AbdulRehmanMehar marked this conversation as resolved.
Outdated
"packageName": "@fluentui/react-button",
"email": "mehars.6925@gmail.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion packages/react-components/react-button/src/components/Button/useButtonStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const buttonClassNames: SlotClassNames<ButtonSlots> = {
const iconSpacingVar = '--fui-Button__icon--spacing';

const buttonSpacingSmall = '3px';
const buttonBorderRadiusSmall = '4px';
Comment thread
sopranopillow marked this conversation as resolved.
Outdated
const buttonSpacingSmallWithIcon = '1px';
const buttonSpacingMedium = '5px';
const buttonSpacingLarge = '8px';
Expand Down Expand Up @@ -243,7 +244,7 @@ const useRootStyles = makeStyles({
minWidth: '64px',
...shorthands.padding(buttonSpacingSmall, tokens.spacingHorizontalS),

...shorthands.borderRadius(buttonSpacingSmall),
...shorthands.borderRadius(buttonBorderRadiusSmall),

fontSize: tokens.fontSizeBase200,
fontWeight: tokens.fontWeightRegular,
Expand Down