Skip to content

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 18, 2023

Previous Behavior

we use plop to create React component scaffold within v9 react package

New Behavior

nx generator to bootstrap react component scaffold within v9 react library.

DEMO:

yarn nx workspace-generator react-component
image

ADDITIONAL NOTES:

A follow up PR will replace create-component npm script aliase to invoke nx generator

Related Issue(s)

@github-actions github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 18, 2023
@Hotell Hotell changed the title Hotell/nx/generators/react component feat(tools): implement react-component generator Jul 18, 2023
@Hotell Hotell force-pushed the hotell/nx/generators/react-component branch from ad3bb2c to d33b90a Compare July 18, 2023 14:40
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 18, 2023

📊 Bundle size report

🤖 This report was generated against 4ba8f4fa6fb612fffc61b9911851b21d8728d9f0

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a275268:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ba8f4fa6fb612fffc61b9911851b21d8728d9f0 (build)

@Hotell Hotell marked this pull request as ready for review July 18, 2023 15:29
@Hotell Hotell requested a review from a team as a code owner July 18, 2023 15:29
@Hotell Hotell merged commit f0bb2f0 into microsoft:master Jul 19, 2023
@Hotell Hotell deleted the hotell/nx/generators/react-component branch July 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants