ci(bundlesize): opt out using --since as lightrail doesnt support this behaviour and needs everything build on every PR #28545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s behaviour and needs everything build on every PR
Hotell
added
Area: Build System
Fluent UI react-northstar (v0)
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 13 | 11 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 602 | 620 | 5000 | |
| Button | mount | 292 | 292 | 5000 | |
| Field | mount | 1071 | 1072 | 5000 | |
| FluentProvider | mount | 651 | 670 | 5000 | |
| FluentProviderWithTheme | mount | 69 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 68 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 69 | 10 | |
| InfoButton | mount | 13 | 11 | 5000 | Possible regression |
| MakeStyles | mount | 847 | 833 | 50000 | |
| Persona | mount | 1699 | 1574 | 5000 | |
| SpinButton | mount | 1305 | 1284 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 90 | 80 | 1.13:1 |
| AlertMinimalPerf.default | 161 | 147 | 1.1:1 |
| ImageMinimalPerf.default | 228 | 212 | 1.08:1 |
| RefMinimalPerf.default | 113 | 105 | 1.08:1 |
| ButtonMinimalPerf.default | 90 | 84 | 1.07:1 |
| InputMinimalPerf.default | 553 | 519 | 1.07:1 |
| AnimationMinimalPerf.default | 306 | 289 | 1.06:1 |
| AvatarMinimalPerf.default | 113 | 107 | 1.06:1 |
| CarouselMinimalPerf.default | 267 | 253 | 1.06:1 |
| DropdownManyItemsPerf.default | 391 | 370 | 1.06:1 |
| PortalMinimalPerf.default | 85 | 80 | 1.06:1 |
| BoxMinimalPerf.default | 198 | 188 | 1.05:1 |
| StatusMinimalPerf.default | 423 | 403 | 1.05:1 |
| TreeWith60ListItems.default | 90 | 86 | 1.05:1 |
| RosterPerf.default | 1544 | 1483 | 1.04:1 |
| ButtonSlotsPerf.default | 314 | 305 | 1.03:1 |
| DropdownMinimalPerf.default | 1428 | 1388 | 1.03:1 |
| EmbedMinimalPerf.default | 1910 | 1861 | 1.03:1 |
| ListNestedPerf.default | 328 | 319 | 1.03:1 |
| MenuButtonMinimalPerf.default | 974 | 950 | 1.03:1 |
| TreeMinimalPerf.default | 483 | 469 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 153 | 150 | 1.02:1 |
| DatepickerMinimalPerf.default | 3568 | 3510 | 1.02:1 |
| FormMinimalPerf.default | 226 | 222 | 1.02:1 |
| LabelMinimalPerf.default | 219 | 214 | 1.02:1 |
| ReactionMinimalPerf.default | 212 | 207 | 1.02:1 |
| TableMinimalPerf.default | 239 | 235 | 1.02:1 |
| ToolbarMinimalPerf.default | 540 | 529 | 1.02:1 |
| ChatMinimalPerf.default | 434 | 431 | 1.01:1 |
| DialogMinimalPerf.default | 444 | 438 | 1.01:1 |
| DividerMinimalPerf.default | 206 | 203 | 1.01:1 |
| HeaderMinimalPerf.default | 212 | 209 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 715 | 708 | 1.01:1 |
| ListMinimalPerf.default | 303 | 300 | 1.01:1 |
| MenuMinimalPerf.default | 502 | 499 | 1.01:1 |
| PopupMinimalPerf.default | 349 | 345 | 1.01:1 |
| TextMinimalPerf.default | 198 | 196 | 1.01:1 |
| ButtonOverridesMissPerf.default | 650 | 647 | 1:1 |
| HeaderSlotsPerf.default | 463 | 461 | 1:1 |
| ProviderMergeThemesPerf.default | 670 | 667 | 1:1 |
| RadioGroupMinimalPerf.default | 262 | 261 | 1:1 |
| SegmentMinimalPerf.default | 196 | 196 | 1:1 |
| TableManyItemsPerf.default | 1133 | 1128 | 1:1 |
| ChatWithPopoverPerf.default | 194 | 195 | 0.99:1 |
| CheckboxMinimalPerf.default | 1123 | 1139 | 0.99:1 |
| FlexMinimalPerf.default | 149 | 151 | 0.99:1 |
| ProviderMinimalPerf.default | 197 | 200 | 0.99:1 |
| SliderMinimalPerf.default | 729 | 735 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2248 | 2264 | 0.99:1 |
| CustomToolbarPrototype.default | 1462 | 1481 | 0.99:1 |
| GridMinimalPerf.default | 192 | 195 | 0.98:1 |
| TextAreaMinimalPerf.default | 286 | 293 | 0.98:1 |
| TooltipMinimalPerf.default | 1248 | 1272 | 0.98:1 |
| AttachmentSlotsPerf.default | 629 | 648 | 0.97:1 |
| CardMinimalPerf.default | 311 | 319 | 0.97:1 |
| ListCommonPerf.default | 381 | 394 | 0.97:1 |
| SkeletonMinimalPerf.default | 193 | 200 | 0.97:1 |
| IconMinimalPerf.default | 365 | 386 | 0.95:1 |
| VideoMinimalPerf.default | 413 | 435 | 0.95:1 |
| ListWith60ListItems.default | 362 | 384 | 0.94:1 |
| LoaderMinimalPerf.default | 182 | 193 | 0.94:1 |
| AccordionMinimalPerf.default | 78 | 84 | 0.93:1 |
| LayoutMinimalPerf.default | 192 | 206 | 0.93:1 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cf63434:
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c3f4b77f8160185518b1fea6d74be239519fba73 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 627 | 628 | 5000 | |
| Breadcrumb | mount | 1678 | 1676 | 1000 | |
| Checkbox | mount | 1681 | 1695 | 5000 | |
| CheckboxBase | mount | 1456 | 1472 | 5000 | |
| ChoiceGroup | mount | 2937 | 2923 | 5000 | |
| ComboBox | mount | 665 | 647 | 1000 | |
| CommandBar | mount | 6245 | 6184 | 1000 | |
| ContextualMenu | mount | 13639 | 13360 | 1000 | |
| DefaultButton | mount | 741 | 745 | 5000 | |
| DetailsRow | mount | 2183 | 2206 | 5000 | |
| DetailsRowFast | mount | 2187 | 2173 | 5000 | |
| DetailsRowNoStyles | mount | 2014 | 1977 | 5000 | |
| Dialog | mount | 2739 | 2667 | 1000 | |
| DocumentCardTitle | mount | 233 | 237 | 1000 | |
| Dropdown | mount | 2031 | 2025 | 5000 | |
| FocusTrapZone | mount | 1143 | 1137 | 5000 | |
| FocusZone | mount | 1068 | 1085 | 5000 | |
| GroupedList | mount | 41259 | 41465 | 2 | |
| GroupedList | virtual-rerender | 19618 | 19818 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50695 | 49989 | 2 | |
| GroupedListV2 | mount | 219 | 222 | 2 | |
| GroupedListV2 | virtual-rerender | 212 | 211 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 231 | 230 | 2 | |
| IconButton | mount | 1081 | 1111 | 5000 | |
| Label | mount | 333 | 328 | 5000 | |
| Layer | mount | 2724 | 2739 | 5000 | |
| Link | mount | 391 | 388 | 5000 | |
| MenuButton | mount | 930 | 945 | 5000 | |
| MessageBar | mount | 21628 | 21480 | 5000 | |
| Nav | mount | 1948 | 1901 | 1000 | |
| OverflowSet | mount | 776 | 782 | 5000 | |
| Panel | mount | 1794 | 1797 | 1000 | |
| Persona | mount | 728 | 751 | 1000 | |
| Pivot | mount | 868 | 881 | 1000 | |
| PrimaryButton | mount | 849 | 842 | 5000 | |
| Rating | mount | 4594 | 4644 | 5000 | |
| SearchBox | mount | 920 | 916 | 5000 | |
| Shimmer | mount | 1862 | 1891 | 5000 | |
| Slider | mount | 1340 | 1317 | 5000 | |
| SpinButton | mount | 2912 | 2842 | 5000 | |
| Spinner | mount | 400 | 389 | 5000 | |
| SplitButton | mount | 1797 | 1813 | 5000 | |
| Stack | mount | 408 | 406 | 5000 | |
| StackWithIntrinsicChildren | mount | 874 | 892 | 5000 | |
| StackWithTextChildren | mount | 2686 | 2665 | 5000 | |
| SwatchColorPicker | mount | 6109 | 6097 | 5000 | |
| TagPicker | mount | 1438 | 1461 | 5000 | |
| Text | mount | 376 | 380 | 5000 | |
| TextField | mount | 955 | 936 | 5000 | |
| ThemeProvider | mount | 822 | 832 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 598 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1279 | 1262 | 5000 | |
| Toggle | mount | 611 | 612 | 5000 | |
| buttonNative | mount | 198 | 193 | 5000 |
tudorpopams
approved these changes
Jul 18, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 18, 2023
* master: ci(bundlesize): opt out using --since as lightrail doesnt support this behaviour and needs everything build on every PR (microsoft#28545) feat: automatically add v9 package stories to public docsite and correctly create codesandbox demo source code (microsoft#28528) applying package updates Keytips: Align keytipData with visible instance for dupes (microsoft#28522) applying package updates V8 Fluent2 Theme: Spinner sizes (microsoft#28512) feat: add extra-tiny size value to size prop (microsoft#28249) feat(react-infobutton): Remove InfoIcon from react-infobutton (microsoft#28534) Made Breadcrumb package public (microsoft#28549) X bars showing incorrect data when the values are large- bug 8380 (microsoft#28510) feat(tools): implement `prepare-initial-release` generator (microsoft#28505) feat: release react-breadcrumb to preview (microsoft#28402) applying package updates fix: v8 SplitButton and split MenuItem have two touch targets when checkable (microsoft#28523) fix(react-infobutton): Apply aria-owns only when the popover is open and cleanup infobutton stories (microsoft#28463) fix: Pivot overflow role uses tab (microsoft#28409) Migrate react-search to preview (microsoft#28531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
lighrail doesnt work with affected builds and needs everything build on every PR.
as we enabled since some time ago, every PR that wont build all projects or has some mixup state from previous PR merged into master get following confusing metrics:
New Behavior
see PR title
Related Issue(s)