Accordion: added openItems to AccordionToggleData #28431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 9 | 13 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 600 | 609 | 5000 | |
| Button | mount | 312 | 295 | 5000 | |
| Field | mount | 1074 | 1022 | 5000 | |
| FluentProvider | mount | 648 | 652 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 87 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 69 | 10 | |
| InfoButton | mount | 9 | 13 | 5000 | Possible regression |
| MakeStyles | mount | 861 | 844 | 50000 | |
| Persona | mount | 1646 | 1612 | 5000 | |
| SpinButton | mount | 1290 | 1317 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b0267b:
|
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesUnable to find bundle size details for Baseline commit: 325743f Possible causes
Recommendations
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
reviewed
Jul 28, 2023
| const open = useAccordionContext_unstable(ctx => ctx.openItems.includes(value)); | ||
| const onAccordionHeaderClick = React.useCallback( | ||
| (ev: AccordionToggleEvent) => requestToggle(ev, { value }), | ||
| (ev: AccordionToggleEvent) => requestToggle(ev, { value, openItems: [] }), |
Contributor
There was a problem hiding this comment.
this looks like a hack. instead of this, how about to simply modify requestToggle signature?
Contributor
|
Closing this in favor of #28665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
There was no property on
AccordionToggleDatawhich provided the consumer with the details of the current open items of the accordion which respect themultipleandcollapsibleprops.New Behavior
openItemsprop has been added toAccordionToggleDataofonTogglewhich respects themultipleandcollapsibleprop and provides the user with the current open items.Related Issue(s)
multipleandcollapsibleprops #27718