Fixing re-render issue for all charts when empty #28321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srmukher
force-pushed
the
users/srmukher/ReRenderFix
branch
from
fbaa80d to
f0889a7
Compare
Collaborator
📊 Bundle size report🤖 This report was generated against 58c60bce83efdf5811adb73c4f2f9b1950109fbf |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 58c60bce83efdf5811adb73c4f2f9b1950109fbf (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10e675e:
|
…ers/srmukher/ReRenderFix
…ers/srmukher/ReRenderFix
AtishayMsft
reviewed
Jul 10, 2023
change/@fluentui-react-charting-556f2e0e-35f0-44cd-9bd6-aa9b24aaa57e.json
Show resolved
Hide resolved
AtishayMsft
reviewed
Jul 10, 2023
packages/react-charting/src/components/Sparkline/__snapshots__/Sparkline.test.tsx.snap
Show resolved
Hide resolved
AtishayMsft
reviewed
Jul 10, 2023
packages/react-charting/src/components/GroupedVerticalBarChart/GroupedVerticalBarChartRTL.tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Jul 10, 2023
packages/react-charting/src/components/HeatMapChart/HeatMapChartRTL.test..tsx
Show resolved
Hide resolved
AtishayMsft
reviewed
Jul 10, 2023
…ers/srmukher/ReRenderFix
…sers/srmukher/ReRenderFix
srmukher
force-pushed
the
users/srmukher/ReRenderFix
branch
from
6fae5e1 to
1afb7d1
Compare
…sers/srmukher/ReRenderFix
…her/fluentui into users/srmukher/ReRenderFix
AtishayMsft
approved these changes
Aug 1, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 1, 2023
* master: (37 commits) release (microsoft#28696) Fixing re-render issue for all charts when empty (microsoft#28321) feat(FluentProvider): emit errors on duplicate IDs (microsoft#28670) applying package updates fix(react-positioning): autoSize causing position update to reach maximum (microsoft#28689) fix(react-tags-preview): fix InteractionTag hover styles (microsoft#28686) Accordion: export AccordionHeaderProvider (microsoft#28542) feat(react-shared-contexts): add AnnounceContext (microsoft#28654) Added VR tests for Breadcrumb (microsoft#28653) fix(react-menu): use outline for menuItem focus ring (microsoft#28685) [Bug]: Tree, vertical spacing of branches and children is inconsistent (microsoft#28681) feaTt(react-tree): adds openItems and checkedItems to tree callback data (microsoft#28669) applying package updates Add mountNode prop to combos (microsoft#28661) react-tags-preview: add more vr test (microsoft#28582) chore: migrate to nx 16.1.4 (microsoft#28583) applying package updates chore: improves internal headless signature (microsoft#28651) fix: remove margin from icon when ToolbarButton is vertical (microsoft#28658) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing re-render issue for all charts when empty.