docs(react-drawer): improve type descriptions and fix TS circular references #28282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marcosmoura
commented
Jun 21, 2023
marcosmoura
commented
- Fixes an issue with TS circular references by simplifying the usage of Drawer base types
- Rename and improve documentation of some types
marcosmoura
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 82 | 81 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 626 | 592 | 5000 | |
| Button | mount | 298 | 303 | 5000 | |
| Field | mount | 1060 | 1057 | 5000 | |
| FluentProvider | mount | 643 | 639 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 81 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 74 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 77 | 10 | |
| InfoButton | mount | 9 | 15 | 5000 | |
| MakeStyles | mount | 857 | 866 | 50000 | |
| Persona | mount | 1639 | 1582 | 5000 | |
| SpinButton | mount | 1287 | 1328 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1a34d5cde97318e5af25d7b9951a76625ee3d94b (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 655d512:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
.../react-components/react-drawer/src/components/DrawerOverlay/useDrawerOverlayStyles.styles.ts
Show resolved
Hide resolved
ValentinaKozlova
approved these changes
Jun 22, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 22, 2023
* master: docs(react-drawer): best practices (microsoft#28040) docs(react-drawer): add missing documentation for Drawer stories (microsoft#28284) docs(react-drawer): improve type descriptions and fix TS circular references (microsoft#28282) docs(react-drawer): improve drawer stories examples (microsoft#28283) bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272) Doc: Tree Infinite Scrolling (microsoft#28197) fix(react-card): infer a11y id from immediate header element (microsoft#28266) Fixed bugs and added more stories to the Breadcrumb (microsoft#28267) refactor: Keep vanillajs code only where needed (microsoft#28278) fix: correcting focus behavior of react-search (microsoft#28241) Tooltip : updated tooltip styles (microsoft#28264)
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.