Skip to content

Fix overlapping axis labels on smaller viewports #28273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krkshitij merged 3 commits into from
Jun 22, 2023
Merged

Fix overlapping axis labels on smaller viewports #28273

krkshitij merged 3 commits into from
Jun 22, 2023

Conversation

@krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Jun 21, 2023

Cherry-pick of #28239

@krkshitij krkshitij requested a review from a team as a code owner June 21, 2023 11:58
@krkshitij krkshitij requested a review from a team as a code owner June 21, 2023 11:58
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 21, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f733e6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@tudorpopams tudorpopams requested a review from Hotell June 21, 2023 12:06
@size-auditor
Copy link

size-auditor bot commented Jun 21, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4837059827e029e16aea3d705ef9937c16469023 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 21, 2023 •
edited
Loading

🕵 FluentUI-v7 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 21, 2023 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 884 906 5000
Breadcrumb mount 26562 26811 5000
Checkbox mount 1327 1353 5000
CheckboxBase mount 1118 1141 5000
ChoiceGroup mount 3584 3480 5000
ComboBox mount 826 809 1000
CommandBar mount 5376 5305 1000
ContextualMenu mount 9889 9651 1000
DefaultButton mount 1011 1010 5000
DetailsRow mount 2731 2707 5000
DetailsRowFast mount 2727 2752 5000
DetailsRowNoStyles mount 2632 2547 5000
Dialog mount 1704 1778 1000
DocumentCardTitle mount 1405 1397 1000
Dropdown mount 1890 1892 5000
FocusTrapZone mount 1286 1314 5000
FocusZone mount 1394 1387 5000
GroupedList mount 632 692 2
GroupedListV2 mount 349 361 2
IconButton mount 1375 1377 5000
Label mount 499 489 5000
Layer mount 1518 1527 5000
Link mount 562 560 5000
MenuButton mount 1247 1234 5000
MessageBar mount 1605 1670 5000
Nav mount 2393 2392 1000
OverflowSet mount 1168 1192 5000
Panel mount 1194 1184 1000
Persona mount 873 903 1000
Pivot mount 1180 1186 1000
PrimaryButton mount 1112 1113 5000
Rating mount 5573 5607 5000
SearchBox mount 1121 1136 5000
Shimmer mount 2005 2018 5000
Slider mount 1283 1261 5000
SpinButton mount 3552 3517 5000
Spinner mount 543 548 5000
SplitButton mount 2288 2276 5000
Stack mount 590 600 5000
StackWithIntrinsicChildren mount 1252 1226 5000
StackWithTextChildren mount 3412 3366 5000
SwatchColorPicker mount 6911 6827 5000
TagPicker mount 2066 1980 5000
TeachingBubble mount 32204 32047 5000
Text mount 556 553 5000
TextField mount 1196 1162 5000
Toggle mount 843 818 5000
button mount 334 317 5000

@krkshitij krkshitij merged commit 69fb28e into microsoft:7.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes

@AtishayMsft AtishayMsft AtishayMsft approved these changes

Assignees

@AtishayMsft AtishayMsft

Labels

Fabric 7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krkshitij @fabricteam @Hotell @AtishayMsft @msft-fluent-ui-bot