Skip to content

Tooltip : updated tooltip styles #28264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behowell merged 4 commits into from
Jun 20, 2023
Merged

Tooltip : updated tooltip styles #28264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d292352
updated tooltip styles
kkakroo Jun 20, 2023
497e6f7
updated style as per review comments
kkakroo Jun 20, 2023
03e2e2f
Merge branch 'master' into tooltip-fix
kkakroo Jun 20, 2023
c6dddb8
updated comment and added vr test
kkakroo Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/vr-tests-react-components/src/stories/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,20 @@ storiesOf('Tooltip Converged', module)
<button>Target</button>
</Tooltip>
</div>
))
.addStory('overflow-wrap', () => (
<div className={useStyles().wrapper}>
<Tooltip visible content="Thistooltiptextislongenoughtobebrokenintoanewline" relationship="description">
<button>Target</button>
</Tooltip>
</div>
))
.addStory('overflow-wrap withArrow', () => (
<div className={useStyles().wrapper}>
<Tooltip visible withArrow content="Thistooltiptextislongenoughtobebrokenintoanewline" relationship="description">
<button>Target</button>
</Tooltip>
</div>
));

const TooltipPositioning: React.FC = () => {
Expand Down
7 changes: 7 additions & 0 deletions change/@fluentui-react-tooltip-0c7f8278-85ad-44f1-82b3-8048cf63b2e7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: added overflowWrap to make sure content does not exceed the tooltip container and added vr test for the same",
"packageName": "@fluentui/react-tooltip",
"email": "kakrookaran@gmail.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-tooltip/src/components/Tooltip/useTooltipStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const useStyles = makeStyles({
fontFamily: tokens.fontFamilyBase,
fontSize: tokens.fontSizeBase200,
lineHeight: tokens.lineHeightBase200,
overflowWrap: 'break-word',

...shorthands.borderRadius(tokens.borderRadiusMedium),
...shorthands.border('1px', 'solid', tokens.colorTransparentStroke),
Expand Down