Skip to content

fix: Alert example missing aria-label for icon #28234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 1 commit into from
Jun 16, 2023
Merged

fix: Alert example missing aria-label for icon #28234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-components/react-alert/stories/Alert/AlertAction.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export const Action = () => (
<Alert
intent="error"
action={{
icon: <DismissCircleRegular aria-label="dismiss message" />,
icon: <DismissCircleRegular />,
'aria-label': 'dismiss message',
}}
>
Save failed
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-alert/stories/Alert/AlertAvatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export const Avatar = () => (
<Alert
action={{
icon: <DismissCircleRegular />,
'aria-label': 'dismiss message',
}}
avatar={{ name: 'John Smith', size: 24, color: 'dark-green' }}
>
Expand Down