Skip to content

Conversation

@krkshitij
Copy link
Contributor

@krkshitij krkshitij commented Jun 14, 2023

Cherry-pick of #27580

@krkshitij krkshitij requested a review from a team as a code owner June 14, 2023 08:34
@msft-fluent-ui-bot msft-fluent-ui-bot added Fabric 7 Package: charting needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master labels Jun 14, 2023
Copy link
Collaborator

@msft-fluent-ui-bot msft-fluent-ui-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).

Please do one of the following:

  • If you've already created a PR to master, add a link to it
  • If the change is irrelevant to version 8, add a comment explaining why
  • Otherwise, create a PR to master with this same change, and add a link to it

After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).

Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6429e9b:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@krkshitij krkshitij removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Jun 14, 2023
@size-auditor
Copy link

size-auditor bot commented Jun 14, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bcb8832dacb593d38e678567321411852482b1fb (build)

@fabricteam
Copy link
Collaborator

🕵 FluentUI-v7 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 0 screenshots added, 1 screenshots removed, 1372 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 1 screenshots
Image Name Diff(in Pixels) Image Type
DocumentCard.With secondary title style.default.chromium.png 0 Removed

@fabricteam
Copy link
Collaborator

Perf Analysis

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
GroupedList mount 605 676 2 Possible regression
All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 858 869 5000
Breadcrumb mount 26317 26445 5000
Checkbox mount 1313 1296 5000
CheckboxBase mount 1110 1127 5000
ChoiceGroup mount 3566 3511 5000
ComboBox mount 800 831 1000
CommandBar mount 5302 5257 1000
ContextualMenu mount 10213 9757 1000
DefaultButton mount 1000 1002 5000
DetailsRow mount 2739 2710 5000
DetailsRowFast mount 2748 2658 5000
DetailsRowNoStyles mount 2566 2619 5000
Dialog mount 1792 1774 1000
DocumentCardTitle mount 1408 1391 1000
Dropdown mount 1837 1846 5000
FocusTrapZone mount 1358 1376 5000
FocusZone mount 1403 1369 5000
GroupedList mount 605 676 2 Possible regression
GroupedListV2 mount 347 359 2
IconButton mount 1380 1375 5000
Label mount 494 492 5000
Layer mount 1518 1525 5000
Link mount 566 563 5000
MenuButton mount 1221 1217 5000
MessageBar mount 1614 1617 5000
Nav mount 2376 2368 1000
OverflowSet mount 1196 1185 5000
Panel mount 1199 1186 1000
Persona mount 905 897 1000
Pivot mount 1137 1147 1000
PrimaryButton mount 1113 1110 5000
Rating mount 5608 5528 5000
SearchBox mount 1144 1131 5000
Shimmer mount 2036 1996 5000
Slider mount 1261 1244 5000
SpinButton mount 3547 3528 5000
Spinner mount 546 548 5000
SplitButton mount 2217 2237 5000
Stack mount 594 586 5000
StackWithIntrinsicChildren mount 1244 1248 5000
StackWithTextChildren mount 3351 3402 5000
SwatchColorPicker mount 6827 6794 5000
TagPicker mount 1996 1954 5000
TeachingBubble mount 31784 31858 5000
Text mount 543 546 5000
TextField mount 1153 1163 5000
Toggle mount 827 831 5000
button mount 333 331 5000

@krkshitij krkshitij merged commit ccc36ec into microsoft:7.0 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants