ci: use ubuntu pool for size-auditor merge job #28208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
hotell/ci/fix-size-auditor-pipelines
branch
from
4b65e4a to
a4f9ace
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 80 | 75 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 598 | 594 | 5000 | |
| Button | mount | 292 | 295 | 5000 | |
| Field | mount | 1021 | 1012 | 5000 | |
| FluentProvider | mount | 648 | 635 | 5000 | |
| FluentProviderWithTheme | mount | 80 | 75 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 62 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 69 | 71 | 10 | |
| InfoButton | mount | 12 | 8 | 5000 | |
| MakeStyles | mount | 856 | 846 | 50000 | |
| Persona | mount | 1607 | 1544 | 5000 | |
| SpinButton | mount | 1271 | 1204 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 102 | 85 | 1.2:1 |
| LoaderMinimalPerf.default | 202 | 174 | 1.16:1 |
| ListCommonPerf.default | 420 | 380 | 1.11:1 |
| AttachmentMinimalPerf.default | 90 | 82 | 1.1:1 |
| TextAreaMinimalPerf.default | 297 | 276 | 1.08:1 |
| TableManyItemsPerf.default | 1193 | 1120 | 1.07:1 |
| ImageMinimalPerf.default | 233 | 220 | 1.06:1 |
| SkeletonMinimalPerf.default | 211 | 199 | 1.06:1 |
| AvatarMinimalPerf.default | 112 | 107 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 148 | 141 | 1.05:1 |
| PortalMinimalPerf.default | 91 | 87 | 1.05:1 |
| ProviderMinimalPerf.default | 201 | 191 | 1.05:1 |
| SliderMinimalPerf.default | 779 | 744 | 1.05:1 |
| TreeMinimalPerf.default | 483 | 458 | 1.05:1 |
| CardMinimalPerf.default | 322 | 311 | 1.04:1 |
| FlexMinimalPerf.default | 158 | 152 | 1.04:1 |
| ListWith60ListItems.default | 372 | 359 | 1.04:1 |
| ProviderMergeThemesPerf.default | 682 | 654 | 1.04:1 |
| HeaderSlotsPerf.default | 479 | 466 | 1.03:1 |
| PopupMinimalPerf.default | 355 | 344 | 1.03:1 |
| RadioGroupMinimalPerf.default | 263 | 256 | 1.03:1 |
| TableMinimalPerf.default | 246 | 238 | 1.03:1 |
| AccordionMinimalPerf.default | 87 | 85 | 1.02:1 |
| BoxMinimalPerf.default | 192 | 188 | 1.02:1 |
| DropdownManyItemsPerf.default | 394 | 385 | 1.02:1 |
| FormMinimalPerf.default | 225 | 220 | 1.02:1 |
| InputMinimalPerf.default | 553 | 541 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 722 | 707 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2321 | 2270 | 1.02:1 |
| CustomToolbarPrototype.default | 1501 | 1467 | 1.02:1 |
| AnimationMinimalPerf.default | 302 | 300 | 1.01:1 |
| ButtonMinimalPerf.default | 88 | 87 | 1.01:1 |
| CarouselMinimalPerf.default | 259 | 257 | 1.01:1 |
| DatepickerMinimalPerf.default | 3627 | 3599 | 1.01:1 |
| LayoutMinimalPerf.default | 204 | 202 | 1.01:1 |
| ListNestedPerf.default | 327 | 324 | 1.01:1 |
| MenuButtonMinimalPerf.default | 968 | 957 | 1.01:1 |
| ToolbarMinimalPerf.default | 539 | 534 | 1.01:1 |
| ChatMinimalPerf.default | 431 | 433 | 1:1 |
| CheckboxMinimalPerf.default | 1126 | 1130 | 1:1 |
| DialogMinimalPerf.default | 454 | 456 | 1:1 |
| DividerMinimalPerf.default | 209 | 208 | 1:1 |
| HeaderMinimalPerf.default | 209 | 208 | 1:1 |
| LabelMinimalPerf.default | 220 | 221 | 1:1 |
| MenuMinimalPerf.default | 506 | 504 | 1:1 |
| RefMinimalPerf.default | 112 | 112 | 1:1 |
| SegmentMinimalPerf.default | 202 | 201 | 1:1 |
| TextMinimalPerf.default | 192 | 192 | 1:1 |
| TooltipMinimalPerf.default | 1277 | 1274 | 1:1 |
| AttachmentSlotsPerf.default | 646 | 652 | 0.99:1 |
| ButtonOverridesMissPerf.default | 655 | 661 | 0.99:1 |
| ButtonSlotsPerf.default | 313 | 315 | 0.99:1 |
| GridMinimalPerf.default | 183 | 185 | 0.99:1 |
| StatusMinimalPerf.default | 390 | 393 | 0.99:1 |
| DropdownMinimalPerf.default | 1415 | 1438 | 0.98:1 |
| EmbedMinimalPerf.default | 1847 | 1894 | 0.98:1 |
| ReactionMinimalPerf.default | 211 | 216 | 0.98:1 |
| VideoMinimalPerf.default | 445 | 455 | 0.98:1 |
| ChatWithPopoverPerf.default | 188 | 193 | 0.97:1 |
| ListMinimalPerf.default | 299 | 307 | 0.97:1 |
| RosterPerf.default | 1511 | 1563 | 0.97:1 |
| AlertMinimalPerf.default | 145 | 156 | 0.93:1 |
| IconMinimalPerf.default | 368 | 398 | 0.92:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c750815:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 630 | 644 | 5000 | |
| Breadcrumb | mount | 1684 | 1664 | 1000 | |
| Checkbox | mount | 1707 | 1705 | 5000 | |
| CheckboxBase | mount | 1467 | 1507 | 5000 | |
| ChoiceGroup | mount | 2934 | 2957 | 5000 | |
| ComboBox | mount | 665 | 659 | 1000 | |
| CommandBar | mount | 6250 | 6253 | 1000 | |
| ContextualMenu | mount | 12627 | 12621 | 1000 | |
| DefaultButton | mount | 765 | 751 | 5000 | |
| DetailsRow | mount | 2154 | 2199 | 5000 | |
| DetailsRowFast | mount | 2133 | 2178 | 5000 | |
| DetailsRowNoStyles | mount | 2035 | 2064 | 5000 | |
| Dialog | mount | 2608 | 2662 | 1000 | |
| DocumentCardTitle | mount | 235 | 226 | 1000 | |
| Dropdown | mount | 2007 | 2009 | 5000 | |
| FocusTrapZone | mount | 1121 | 1137 | 5000 | |
| FocusZone | mount | 1088 | 1037 | 5000 | |
| GroupedList | mount | 41378 | 41610 | 2 | |
| GroupedList | virtual-rerender | 20012 | 20130 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50661 | 50849 | 2 | |
| GroupedListV2 | mount | 223 | 221 | 2 | |
| GroupedListV2 | virtual-rerender | 202 | 214 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 227 | 231 | 2 | |
| IconButton | mount | 1075 | 1082 | 5000 | |
| Label | mount | 325 | 336 | 5000 | |
| Layer | mount | 2716 | 2695 | 5000 | |
| Link | mount | 385 | 400 | 5000 | |
| MenuButton | mount | 954 | 983 | 5000 | |
| MessageBar | mount | 21321 | 21322 | 5000 | |
| Nav | mount | 1950 | 1961 | 1000 | |
| OverflowSet | mount | 783 | 773 | 5000 | |
| Panel | mount | 2007 | 1795 | 1000 | |
| Persona | mount | 742 | 751 | 1000 | |
| Pivot | mount | 873 | 856 | 1000 | |
| PrimaryButton | mount | 858 | 819 | 5000 | |
| Rating | mount | 4581 | 4628 | 5000 | |
| SearchBox | mount | 915 | 935 | 5000 | |
| Shimmer | mount | 1955 | 1928 | 5000 | |
| Slider | mount | 1364 | 1283 | 5000 | |
| SpinButton | mount | 2853 | 2835 | 5000 | |
| Spinner | mount | 394 | 387 | 5000 | |
| SplitButton | mount | 1846 | 1816 | 5000 | |
| Stack | mount | 402 | 401 | 5000 | |
| StackWithIntrinsicChildren | mount | 860 | 862 | 5000 | |
| StackWithTextChildren | mount | 2639 | 2668 | 5000 | |
| SwatchColorPicker | mount | 6188 | 6184 | 5000 | |
| TagPicker | mount | 1444 | 1483 | 5000 | |
| Text | mount | 368 | 366 | 5000 | |
| TextField | mount | 955 | 949 | 5000 | |
| ThemeProvider | mount | 852 | 839 | 5000 | |
| ThemeProvider | virtual-rerender | 601 | 569 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1274 | 1269 | 5000 | |
| Toggle | mount | 611 | 586 | 5000 | |
| buttonNative | mount | 191 | 197 | 5000 |
Hotell
force-pushed
the
hotell/ci/fix-size-auditor-pipelines
branch
from
a4f9ace to
c750815
Compare
Asset size changesUnable to find bundle size details for Baseline commit: 36aacc5 Possible causes
Recommendations
|
TristanWatanabe
approved these changes
Jun 13, 2023
TristanWatanabe
added a commit
to TristanWatanabe/fluentui
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
windows-2019 is not supported since 2021 and suddenly started causing issues when installing jq via chocolatey. this started blocking all of our PR's
New Behavior
mergejob migrated to our Ubuntu hosted pool which unifies our CI with rest of our jobs - also making this not fail randomly.Related Issue(s)