Skip to content

Conversation

@tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented Jun 12, 2023

This PR is to update the version of @fluentui/react-icons in our repo to the latest. This picks up IconDirectionContext as well as some performance optimizations, as well as newly added icons.

Fixes #27923

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 484640c:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@tomi-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@tudorpopams tudorpopams requested a review from Hotell June 13, 2023 12:12
@tudorpopams tudorpopams assigned tomi-msft and unassigned marcosmoura Jun 13, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
88.552 kB
26.801 kB
88.064 kB
26.659 kB
-488 B
-142 B
react-alert
Alert
93.624 kB
22.563 kB
82.552 kB
21.771 kB
-11.072 kB
-792 B
react-avatar
Avatar
57.872 kB
15.115 kB
47.7 kB
14.504 kB
-10.172 kB
-611 B
react-avatar
AvatarGroupItem
74.048 kB
19.605 kB
63.876 kB
18.984 kB
-10.172 kB
-621 B
react-badge
PresenceBadge
32.171 kB
8.431 kB
22.213 kB
7.872 kB
-9.958 kB
-559 B
react-button
MenuButton
41.463 kB
10.846 kB
40.965 kB
10.705 kB
-498 B
-141 B
react-button
SplitButton
49.685 kB
12.426 kB
49.197 kB
12.27 kB
-488 B
-156 B
react-checkbox
Checkbox
34.536 kB
10.884 kB
33.164 kB
10.699 kB
-1.372 kB
-185 B
react-combobox
Combobox (including child components)
87.915 kB
28.321 kB
86.98 kB
28.084 kB
-935 B
-237 B
react-combobox
Dropdown (including child components)
86.254 kB
27.93 kB
85.321 kB
27.675 kB
-933 B
-255 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
211.295 kB
58.801 kB
210.103 kB
58.624 kB
-1.192 kB
-177 B
react-datepicker-compat
DatePicker Compat
222.768 kB
59.29 kB
221.601 kB
59.012 kB
-1.167 kB
-278 B
react-dialog
Dialog (including children components)
92.16 kB
27.502 kB
91.673 kB
27.385 kB
-487 B
-117 B
react-field
Field
18.936 kB
7.092 kB
18.003 kB
6.931 kB
-933 B
-161 B
react-infobutton
InfoButton
132.646 kB
40.467 kB
131.018 kB
40.224 kB
-1.628 kB
-243 B
react-infobutton
InfoLabel
136.111 kB
41.528 kB
134.483 kB
41.291 kB
-1.628 kB
-237 B
react-menu
Menu (including children components)
133.373 kB
40.617 kB
132.175 kB
40.453 kB
-1.198 kB
-164 B
react-menu
Menu (including selectable components)
136.357 kB
41.146 kB
134.939 kB
40.948 kB
-1.418 kB
-198 B
react-persona
Persona
64.793 kB
17.036 kB
54.621 kB
16.435 kB
-10.172 kB
-601 B
react-radio
Radio
27.44 kB
8.73 kB
26.952 kB
8.608 kB
-488 B
-122 B
react-select
Select
25.409 kB
8.834 kB
24.915 kB
8.708 kB
-494 B
-126 B
react-spinbutton
SpinButton
34.157 kB
10.429 kB
33.452 kB
10.296 kB
-705 B
-133 B
react-switch
Switch
29.96 kB
9.353 kB
29.472 kB
9.226 kB
-488 B
-127 B
react-table
DataGrid
157.723 kB
43.023 kB
155.895 kB
42.648 kB
-1.828 kB
-375 B
react-table
Table (Primitives only)
45.147 kB
12.577 kB
44.424 kB
12.421 kB
-723 B
-156 B
react-table
Table as DataGrid
133.392 kB
34.008 kB
131.551 kB
33.673 kB
-1.841 kB
-335 B
react-table
Table (Selection only)
79.161 kB
19.386 kB
77.333 kB
19.11 kB
-1.828 kB
-276 B
react-table
Table (Sort only)
78.491 kB
19.195 kB
76.663 kB
18.921 kB
-1.828 kB
-274 B
react-tags
Tag
22.04 kB
7.94 kB
21.277 kB
7.786 kB
-763 B
-154 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
3.194 kB
1.315 kB
react-avatar
AvatarGroup
15.682 kB
6.306 kB
react-badge
Badge
23.591 kB
7.264 kB
react-badge
CounterBadge
24.493 kB
7.565 kB
react-button
Button
36.778 kB
9.51 kB
react-button
CompoundButton
43.932 kB
10.99 kB
react-button
ToggleButton
55.06 kB
11.446 kB
react-card
Card - All
88.752 kB
25.122 kB
react-card
Card
83.687 kB
23.666 kB
react-card
CardFooter
9.229 kB
3.9 kB
react-card
CardHeader
11.125 kB
4.596 kB
react-card
CardPreview
10.034 kB
4.248 kB
react-components
react-components: Button, FluentProvider & webLightTheme
64.935 kB
17.918 kB
react-components
react-components: FluentProvider & webLightTheme
36.168 kB
11.964 kB
react-divider
Divider
17.477 kB
6.357 kB
react-image
Image
11.55 kB
4.627 kB
react-input
Input
24.219 kB
7.781 kB
react-label
Label
10.175 kB
4.243 kB
react-link
Link
12.375 kB
5.113 kB
react-overflow
hooks only
11.206 kB
4.266 kB
react-popover
Popover
119.608 kB
36.799 kB
react-portal
Portal
11.82 kB
4.391 kB
react-portal-compat
PortalCompatProvider
6.473 kB
2.196 kB
react-positioning
usePositioning
24.249 kB
8.856 kB
react-progress
ProgressBar
13.927 kB
5.488 kB
react-provider
FluentProvider
18.115 kB
6.719 kB
react-radio
RadioGroup
11.362 kB
4.753 kB
react-slider
Slider
34.358 kB
11.107 kB
react-spinner
Spinner
21.363 kB
7.021 kB
react-text
Text - Default
12.563 kB
4.972 kB
react-text
Text - Wrappers
15.713 kB
5.293 kB
react-textarea
Textarea
27.69 kB
9.125 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.33 kB
6.764 kB
react-theme
Teams: Light theme
17.895 kB
5.162 kB
react-tooltip
Tooltip
47.263 kB
16.585 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 8e008f74cd77d16ff0983fda2caaa7166ca50fc4

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 13, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 614 5000
Breadcrumb mount 1696 1662 1000
Checkbox mount 1696 1664 5000
CheckboxBase mount 1448 1465 5000
ChoiceGroup mount 2942 2917 5000
ComboBox mount 645 660 1000
CommandBar mount 6276 6291 1000
ContextualMenu mount 14586 13719 1000
DefaultButton mount 734 740 5000
DetailsRow mount 2174 2223 5000
DetailsRowFast mount 2185 2151 5000
DetailsRowNoStyles mount 2012 1997 5000
Dialog mount 2627 2650 1000
DocumentCardTitle mount 236 239 1000
Dropdown mount 1981 1981 5000
FocusTrapZone mount 1119 1128 5000
FocusZone mount 1041 1091 5000
GroupedList mount 40968 41312 2
GroupedList virtual-rerender 19788 19691 2
GroupedList virtual-rerender-with-unmount 50644 51238 2
GroupedListV2 mount 233 226 2
GroupedListV2 virtual-rerender 214 209 2
GroupedListV2 virtual-rerender-with-unmount 239 229 2
IconButton mount 1087 1064 5000
Label mount 338 339 5000
Layer mount 2760 2701 5000
Link mount 386 383 5000
MenuButton mount 920 927 5000
MessageBar mount 21355 21231 5000
Nav mount 1910 1924 1000
OverflowSet mount 783 780 5000
Panel mount 1749 1771 1000
Persona mount 739 759 1000
Pivot mount 893 873 1000
PrimaryButton mount 837 836 5000
Rating mount 4541 4549 5000
SearchBox mount 888 900 5000
Shimmer mount 1862 1863 5000
Slider mount 1326 1323 5000
SpinButton mount 2829 2847 5000
Spinner mount 397 390 5000
SplitButton mount 1794 1811 5000
Stack mount 415 416 5000
StackWithIntrinsicChildren mount 840 846 5000
StackWithTextChildren mount 2622 2667 5000
SwatchColorPicker mount 6175 6108 5000
TagPicker mount 1446 1448 5000
Text mount 360 375 5000
TextField mount 894 948 5000
ThemeProvider mount 842 834 5000
ThemeProvider virtual-rerender 595 586 5000
ThemeProvider virtual-rerender-with-unmount 1260 1278 5000
Toggle mount 602 592 5000
buttonNative mount 189 197 5000

@tomi-msft tomi-msft merged commit 8a5ae3a into microsoft:master Jun 14, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/[email protected] has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: @fluentui/react-icons is missing Subtract sizes 12, 16 and 20

8 participants