Skip to content

fix: MenuItem content should be spaced 12px from the boundary #28162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling1726 merged 3 commits into from
Jul 20, 2023
Merged

fix: MenuItem content should be spaced 12px from the boundary #28162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c353b1
fix: Reduce MenuItem padding to fit design spec
ling1726 Jun 7, 2023
cd924e5
changefiole
ling1726 Jun 7, 2023
4bdddbb
Merge branch 'master' into react-menu/fix/menu-item-padding
ling1726 Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-menu-aef37040-8637-4913-8689-7e7ffd018b46.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
ling1726 marked this conversation as resolved.
Comment thread
ling1726 marked this conversation as resolved.
"type": "patch",
"comment": "fix: MenuItem content should be spaced 12px from the boundary",
"packageName": "@fluentui/react-menu",
"email": "lingfangao@hotmail.com",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/react-components/react-menu/src/components/MenuItem/useMenuItemStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const useStyles = makeStyles({
position: 'relative',
color: tokens.colorNeutralForeground2,
backgroundColor: tokens.colorNeutralBackground1,
paddingRight: '10px',
paddingLeft: '10px',
paddingRight: '6px',
paddingLeft: '6px',
height: '32px',
display: 'flex',
alignItems: 'center',
Expand Down