chore(react-infobutton): Add InfoTip component scaffold #28071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 629df3c452dd3d0fd83472eb78ab8c98e22eb96e (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
…nfobutton/infoTip-scaffold
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 12 | 12 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 573 | 568 | 5000 | |
| Button | mount | 293 | 295 | 5000 | |
| Field | mount | 1036 | 1024 | 5000 | |
| FluentProvider | mount | 656 | 644 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 74 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 75 | 10 | |
| InfoButton | mount | 12 | 12 | 5000 | Possible regression |
| MakeStyles | mount | 874 | 854 | 50000 | |
| Persona | mount | 1634 | 1591 | 5000 | |
| SpinButton | mount | 1273 | 1252 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 339830d:
|
spmonahan
approved these changes
May 31, 2023
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the InfoTip component scaffold. InfoTip is another use case of a info bubble, we currently have an InfoButton that requires the user to click a button to get the information and InfoTip provides focus/hover toggle behavior. InfoTip is useful when there's focusable items while InfoTip is useful for short text and when there's no focusable elements.