feat(tokens): Add status color tokens #28006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size report
Unchanged fixtures
|
miroslavstastny
force-pushed
the
feat/semantic-color-tokens
branch
from
caf4451 to
57973da
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 11 | 13 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 583 | 601 | 5000 | |
| Button | mount | 290 | 301 | 5000 | |
| Field | mount | 1041 | 1064 | 5000 | |
| FluentProvider | mount | 672 | 653 | 5000 | |
| FluentProviderWithTheme | mount | 73 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 65 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 68 | 10 | |
| InfoButton | mount | 11 | 13 | 5000 | Possible regression |
| MakeStyles | mount | 825 | 869 | 50000 | |
| Persona | mount | 1620 | 1636 | 5000 | |
| SpinButton | mount | 1311 | 1317 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e6e662c52a7a7d9c4a9f95e01e1e2194f4e72b04 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 771f040:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
miroslavstastny
commented
May 25, 2023
miroslavstastny
force-pushed
the
feat/semantic-color-tokens
branch
from
bbe63b9 to
e587df9
Compare
github-actions
bot
modified the milestones:
May Project Cycle Q2 2023,
June Project Cycle Q2 2023
miroslavstastny
force-pushed
the
feat/semantic-color-tokens
branch
from
a5887ae to
888b51b
Compare
github-actions
bot
modified the milestones:
June Project Cycle Q2 2023,
July Project Cycle Q3 2023
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
miroslavstastny
force-pushed
the
feat/semantic-color-tokens
branch
from
888b51b to
771f040
Compare
marcosmoura
approved these changes
Jul 31, 2023
Contributor
marcosmoura
left a comment
marcosmoura
left a comment
There was a problem hiding this comment.
Approved for files owned by @microsoft/fluentui-react-build
ling1726
approved these changes
Aug 1, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 7, 2023
* master: chore(cxe-prg): migrate to new slot API (microsoft#28752) chore(teams-prg): migrate to new slot API (microsoft#28751) chore: re-export slot and assertSlots methods (microsoft#28755) Docs(react-tree): Improve docs and stories (microsoft#28741) feat: implements nested tree selection (microsoft#28668) applying package updates applying package updates feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373) fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469) bugfix: ensures controlled state works properly + (microsoft#28665) feat(tokens): Add status color tokens (microsoft#28006) feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638) Made BreadcrumbButton consistent with Item and Link (microsoft#28672)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 7, 2023
* master: chore(cxe-prg): migrate to new slot API (microsoft#28752) chore(teams-prg): migrate to new slot API (microsoft#28751) chore: re-export slot and assertSlots methods (microsoft#28755) Docs(react-tree): Improve docs and stories (microsoft#28741) feat: implements nested tree selection (microsoft#28668) applying package updates applying package updates feature(react-utilities): implements new slot methods (`slot` and `assertSlots`) (microsoft#28373) fix(TimePicker): Selection now works in locales that don't use "am"/"pm" in their time format (microsoft#28469) bugfix: ensures controlled state works properly + (microsoft#28665) feat(tokens): Add status color tokens (microsoft#28006) feat(tokens): Add colorBrandStroke2Contrast and colorNeutralStrokeAlpha2 (microsoft#28638) Made BreadcrumbButton consistent with Item and Link (microsoft#28672) fix(EventListener): do not use `defaultProps` (microsoft#28725)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds status color tokens to theme
tokenspackage.It adds
success,warninganddangertokens which are mapped:success ➡️
greenwarning ➡️
orangedanger ➡️
cranberryEach status color defines 10 tokens with the following mapping in individual themes:
colorStatus${color}Background1colorStatus${color}Background2colorStatus${color}Background3colorStatus${color}Foreground1colorStatus${color}Foreground2colorStatus${color}Foreground3colorStatus${color}ForegroundInvertedcolorStatus${color}BorderActivecolorStatus${color}Border1colorStatus${color}Border2Where
${color}is one ofsuccess,warninganddanger. The mapping is the same for all three status colors with the following one-off overrides:This are the hex values of all status tokens in code:
The tokens are currently not used anywhere in component styles.