chore: add test-ssr to buildci script #27899

layershifter · 2023-05-18T09:15:06Z

New Behavior

This PR adds test-ssr script to "buildci" script and modifies Lage's config, so the scripts will start to run on CI.

Related Issue(s)

Previous PRs: #27444, #27463, #27690

Next steps:

Add implementation to @fluentui/scripts-test-ssr
Drop testing logic from @fluentui/ssr-tests-v9

codesandbox-ci · 2023-05-18T09:27:00Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02c1d83:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2023-05-18T09:27:24Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: dc86a4ef3e06e3828ccf86961f23289a50718faf (build)

fabricteam · 2023-05-18T09:30:13Z

🕵 fluentuiv8 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:30:25Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	842	844	5000
Button	mount	454	450	5000
Field	mount	1527	1555	5000
FluentProvider	mount	1048	1038	5000
FluentProviderWithTheme	mount	132	135	10
FluentProviderWithTheme	virtual-rerender	110	119	10
FluentProviderWithTheme	virtual-rerender-with-unmount	121	132	10
InfoButton	mount	28	19	5000
MakeStyles	mount	1255	1329	50000
Persona	mount	2414	2391	5000
SpinButton	mount	1902	1992	5000

fabricteam · 2023-05-18T09:33:42Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	149	122	1.22:1
ChatDuplicateMessagesPerf.default	248	222	1.12:1
BoxMinimalPerf.default	332	301	1.1:1
ButtonMinimalPerf.default	149	136	1.1:1
ChatMinimalPerf.default	734	672	1.09:1
DividerMinimalPerf.default	360	331	1.09:1
LoaderMinimalPerf.default	339	311	1.09:1
CardMinimalPerf.default	532	496	1.07:1
RadioGroupMinimalPerf.default	449	420	1.07:1
SegmentMinimalPerf.default	336	314	1.07:1
TreeWith60ListItems.default	139	130	1.07:1
AvatarMinimalPerf.default	189	178	1.06:1
AccordionMinimalPerf.default	136	129	1.05:1
ListWith60ListItems.default	647	614	1.05:1
SkeletonMinimalPerf.default	340	323	1.05:1
IconMinimalPerf.default	661	630	1.05:1
AlertMinimalPerf.default	268	258	1.04:1
ListNestedPerf.default	557	534	1.04:1
PortalMinimalPerf.default	141	135	1.04:1
TextMinimalPerf.default	330	317	1.04:1
AttachmentSlotsPerf.default	1079	1049	1.03:1
ButtonSlotsPerf.default	526	509	1.03:1
DatepickerMinimalPerf.default	5796	5650	1.03:1
DialogMinimalPerf.default	745	723	1.03:1
LabelMinimalPerf.default	368	356	1.03:1
TableManyItemsPerf.default	1948	1892	1.03:1
AnimationMinimalPerf.default	454	444	1.02:1
ButtonOverridesMissPerf.default	1044	1026	1.02:1
CheckboxMinimalPerf.default	2077	2039	1.02:1
DropdownManyItemsPerf.default	667	657	1.02:1
DropdownMinimalPerf.default	2207	2174	1.02:1
EmbedMinimalPerf.default	3029	2980	1.02:1
ReactionMinimalPerf.default	359	351	1.02:1
TooltipMinimalPerf.default	2059	2028	1.02:1
GridMinimalPerf.default	313	311	1.01:1
HeaderSlotsPerf.default	793	789	1.01:1
LayoutMinimalPerf.default	328	326	1.01:1
MenuMinimalPerf.default	817	809	1.01:1
TableMinimalPerf.default	398	395	1.01:1
ToolbarMinimalPerf.default	873	862	1.01:1
VideoMinimalPerf.default	711	702	1.01:1
CarouselMinimalPerf.default	448	447	1:1
ListMinimalPerf.default	497	496	1:1
MenuButtonMinimalPerf.default	1644	1638	1:1
ProviderMinimalPerf.default	319	318	1:1
SliderMinimalPerf.default	1093	1095	1:1
SplitButtonMinimalPerf.default	3830	3837	1:1
ChatWithPopoverPerf.default	299	303	0.99:1
FlexMinimalPerf.default	247	250	0.99:1
FormMinimalPerf.default	368	372	0.99:1
HeaderMinimalPerf.default	355	359	0.99:1
InputMinimalPerf.default	892	905	0.99:1
ItemLayoutMinimalPerf.default	1213	1220	0.99:1
CustomToolbarPrototype.default	2170	2196	0.99:1
ImageMinimalPerf.default	396	405	0.98:1
ListCommonPerf.default	668	683	0.98:1
RosterPerf.default	2464	2502	0.98:1
ProviderMergeThemesPerf.default	1089	1112	0.98:1
RefMinimalPerf.default	157	160	0.98:1
StatusMinimalPerf.default	658	671	0.98:1
TreeMinimalPerf.default	770	782	0.98:1
PopupMinimalPerf.default	543	587	0.93:1
TextAreaMinimalPerf.default	476	519	0.92:1

fabricteam · 2023-05-18T09:34:12Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`560 B` `352 B`
`priority-overflow` createOverflowManager	`3.194 kB` `1.315 kB`
`react-accordion` Accordion (including children components)	`86.064 kB` `26.1 kB`
`react-alert` Alert	`93.534 kB` `22.497 kB`
`react-avatar` Avatar	`57.754 kB` `15.041 kB`
`react-avatar` AvatarGroup	`15.632 kB` `6.258 kB`
`react-avatar` AvatarGroupItem	`73.968 kB` `19.552 kB`
`react-badge` Badge	`23.512 kB` `7.197 kB`
`react-badge` CounterBadge	`24.416 kB` `7.506 kB`
`react-badge` PresenceBadge	`32.094 kB` `8.367 kB`
`react-button` Button	`36.724 kB` `9.458 kB`
`react-button` CompoundButton	`43.873 kB` `10.939 kB`
`react-button` MenuButton	`41.411 kB` `10.791 kB`
`react-button` SplitButton	`49.635 kB` `12.364 kB`
`react-button` ToggleButton	`54.866 kB` `11.367 kB`
`react-card` Card - All	`86.061 kB` `24.345 kB`
`react-card` Card	`80.997 kB` `22.895 kB`
`react-card` CardFooter	`9.158 kB` `3.844 kB`
`react-card` CardHeader	`11.048 kB` `4.538 kB`
`react-card` CardPreview	`9.963 kB` `4.192 kB`
`react-checkbox` Checkbox	`34.268 kB` `10.793 kB`
`react-combobox` Combobox (including child components)	`87.251 kB` `28.1 kB`
`react-combobox` Dropdown (including child components)	`85.635 kB` `27.697 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`64.855 kB` `17.852 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`203.937 kB` `57.086 kB`
`react-components` react-components: FluentProvider & webLightTheme	`36.086 kB` `11.9 kB`
`react-datepicker-compat` DatePicker Compat	`220.303 kB` `58.486 kB`
`react-dialog` Dialog (including children components)	`90.204 kB` `26.857 kB`
`react-divider` Divider	`17.399 kB` `6.298 kB`
`react-field` Field	`18.864 kB` `7.004 kB`
`react-image` Image	`11.479 kB` `4.573 kB`
`react-infobutton` InfoButton	`127.977 kB` `39.012 kB`
`react-infobutton` InfoLabel	`131.447 kB` `40.071 kB`
`react-input` Input	`24.024 kB` `7.682 kB`
`react-label` Label	`10.104 kB` `4.185 kB`
`react-link` Link	`12.304 kB` `5.061 kB`
`react-menu` Menu (including children components)	`128.254 kB` `39.184 kB`
`react-menu` Menu (including selectable components)	`131.238 kB` `39.7 kB`
`react-overflow` hooks only	`11.214 kB` `4.271 kB`
`react-persona` Persona	`64.675 kB` `16.968 kB`
`react-popover` Popover	`114.969 kB` `35.392 kB`
`react-portal` Portal	`11.649 kB` `4.262 kB`
`react-portal-compat` PortalCompatProvider	`6.446 kB` `2.186 kB`
`react-positioning` usePositioning	`24.008 kB` `8.798 kB`
`react-progress` ProgressBar	`13.856 kB` `5.434 kB`
`react-provider` FluentProvider	`18.033 kB` `6.666 kB`
`react-radio` Radio	`27.282 kB` `8.661 kB`
`react-radio` RadioGroup	`11.312 kB` `4.71 kB`
`react-select` Select	`25.357 kB` `8.798 kB`
`react-slider` Slider	`34.164 kB` `11.024 kB`
`react-spinbutton` SpinButton	`33.934 kB` `10.328 kB`
`react-spinner` Spinner	`20.882 kB` `6.798 kB`
`react-switch` Switch	`29.806 kB` `9.274 kB`
`react-table` DataGrid	`147.583 kB` `40.523 kB`
`react-table` Table (Primitives only)	`44.348 kB` `12.347 kB`
`react-table` Table as DataGrid	`130.142 kB` `33.083 kB`
`react-table` Table (Selection only)	`78.056 kB` `19.084 kB`
`react-table` Table (Sort only)	`77.386 kB` `18.896 kB`
`react-tags` Tag	`20.637 kB` `7.332 kB`
`react-text` Text - Default	`12.492 kB` `4.92 kB`
`react-text` Text - Wrappers	`15.624 kB` `5.232 kB`
`react-textarea` Textarea	`27.545 kB` `9.064 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.33 kB` `6.764 kB`
`react-theme` Teams: Light theme	`17.895 kB` `5.162 kB`
`react-tooltip` Tooltip	`46.708 kB` `16.376 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against dc86a4ef3e06e3828ccf86961f23289a50718faf}

fabricteam · 2023-05-18T09:41:14Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:42:46Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-05-18T09:51:43Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	950	972	5000
Breadcrumb	mount	2603	2601	1000
Checkbox	mount	2544	2577	5000
CheckboxBase	mount	2256	2238	5000
ChoiceGroup	mount	4365	4462	5000
ComboBox	mount	1060	1053	1000
CommandBar	mount	9423	9492	1000
ContextualMenu	mount	17261	17397	1000
DefaultButton	mount	1143	1179	5000
DetailsRow	mount	3405	3421	5000
DetailsRowFast	mount	3522	3403	5000
DetailsRowNoStyles	mount	3206	3257	5000
Dialog	mount	4077	4056	1000
DocumentCardTitle	mount	382	368	1000
Dropdown	mount	3064	3041	5000
FocusTrapZone	mount	1786	1819	5000
FocusZone	mount	1706	1764	5000
GroupedList	mount	58428	68894	2
GroupedList	virtual-rerender	28830	29073	2
GroupedList	virtual-rerender-with-unmount	88973	86380	2
GroupedListV2	mount	376	380	2
GroupedListV2	virtual-rerender	365	362	2
GroupedListV2	virtual-rerender-with-unmount	385	372	2
IconButton	mount	1747	1698	5000
Label	mount	545	545	5000
Layer	mount	4325	4194	5000
Link	mount	636	625	5000
MenuButton	mount	1406	1485	5000
MessageBar	mount	33044	33225	5000
Nav	mount	3036	3057	1000
OverflowSet	mount	1202	1251	5000
Panel	mount	2656	2676	1000
Persona	mount	1144	1137	1000
Pivot	mount	1427	1426	1000
PrimaryButton	mount	1294	1320	5000
Rating	mount	6825	6820	5000
SearchBox	mount	1397	1342	5000
Shimmer	mount	2718	2796	5000
Slider	mount	2075	2022	5000
SpinButton	mount	4513	4468	5000
Spinner	mount	626	612	5000
SplitButton	mount	2872	2875	5000
Stack	mount	632	633	5000
StackWithIntrinsicChildren	mount	1362	1340	5000
StackWithTextChildren	mount	3851	3885	5000
SwatchColorPicker	mount	9660	9653	5000
TagPicker	mount	2405	2430	5000
Text	mount	604	590	5000
TextField	mount	1454	1472	5000
ThemeProvider	mount	1392	1364	5000
ThemeProvider	virtual-rerender	956	929	5000
ThemeProvider	virtual-rerender-with-unmount	2142	2035	5000
Toggle	mount	968	954	5000
buttonNative	mount	343	334	5000

* master: feat(react-drawer): create DrawerHeader component (microsoft#27582) chore: add test-ssr to buildci script (microsoft#27899) applying package updates

chore: add test-ssr to buildci script

02c1d83

msft-fluent-ui-bot assigned TristanWatanabe May 18, 2023

layershifter marked this pull request as ready for review May 18, 2023 09:15

layershifter requested a review from a team as a code owner May 18, 2023 09:15

github-actions bot added this to the May Project Cycle Q2 2023 milestone May 18, 2023

tudorpopams requested a review from Hotell May 18, 2023 12:11

Hotell approved these changes May 18, 2023

View reviewed changes

layershifter merged commit 727ef70 into microsoft:master May 18, 2023

layershifter deleted the chore/enable-test-ssr branch May 18, 2023 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: add test-ssr to buildci script #27899

chore: add test-ssr to buildci script #27899

Uh oh!

layershifter commented May 18, 2023 •

edited

Loading

Uh oh!

codesandbox-ci bot commented May 18, 2023

Uh oh!

size-auditor bot commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

fabricteam commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: add test-ssr to buildci script #27899

chore: add test-ssr to buildci script #27899

Uh oh!

Conversation

layershifter commented May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Related Issue(s)

Uh oh!

codesandbox-ci bot commented May 18, 2023

Uh oh!

size-auditor bot commented May 18, 2023

Asset size changes

Uh oh!

fabricteam commented May 18, 2023

🕵 fluentuiv8 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 18, 2023

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented May 18, 2023

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 18, 2023

📊 Bundle size report

Uh oh!

fabricteam commented May 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 18, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented May 18, 2023

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

layershifter commented May 18, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)